Review main Merged

76074[TASK] Turn TypoScriptFrontendController tests into functionals

Christian Kuhn CR +2 V +2 Hard +234 −403 updated 10/10/22, 16:45

Commit message

Stop a naughty mocking party provided by
TypoScriptFrontendController unit tests by
turning most of them into functionals.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/10/22, 15:47

  2. Christian Kuhn updated the commit message in patch set 2 10/10/22, 15:50

  3. core-ci voted on patch set 1 V +1 10/10/22, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32146

  4. core-ci voted on patch set 2 V +1 10/10/22, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32147

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/10/22, 16:35

  6. Jochen Roth voted on patch set 2 V +1 CR +1 10/10/22, 16:44

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/10/22, 16:45

  8. Christian Kuhn merged patch set 3 10/10/22, 16:45