Review main Merged

76077[FEATURE] Use password policy for password reset in ext:backend

Torben Hansen CR +2 V +2 Normal +85 −9 updated 10/20/22, 17:49

Commit message

The password reset feature for TYPO3 backend users does now consider the
configurable password policy introduced in #97388.

The formerly hardcoded minimum length of 8 chars for the new password
has been removed. Instead, the globally configured password policy is now
taken into account when a TYPO3 backend user resets the password. The
TYPO3 default password policy contains the following password requirements:

* At least 8 chars
* At least one number
* At least one upper case char
* At least one special char
* Must be different than current password (if available)

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1419

  1. Torben Hansen uploaded patch set 1 10/10/22, 17:50

  2. core-ci voted on patch set 1 V +1 10/10/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32155

  3. Chris Müller uploaded patch set 2 10/10/22, 18:42

  4. core-ci voted on patch set 2 V +1 10/10/22, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32156

  5. Benni Mack commented on patch set 2 10/11/22, 06:39

    nice job!
  6. Torben Hansen uploaded patch set 3 10/11/22, 16:10

  7. core-ci voted on patch set 3 V +1 10/11/22, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32216

  8. Georg Ringer commented on patch set 3 CR -1 10/11/22, 22:08

    locallang_reset_password.xlf:13

    please use a different identifier because otherwise translaitons will also end in other languages and there is a different meaning
  9. Torben Hansen uploaded patch set 4 10/12/22, 04:17

  10. Torben Hansen commented on patch set 3 10/12/22, 04:18

    locallang_reset_password.xlf:13 Reply

    I now renamed the label identifier, since the old label is not used any more.
  11. core-ci voted on patch set 4 V +1 10/12/22, 04:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32233

  12. Georg Ringer voted on patch set 4 V +1 CR +1 10/12/22, 07:58

  13. Christian Kuhn commented on patch set 4 10/12/22, 08:03

    Feature-97391-UsePasswordPolicyForPasswordResetInExtbackend.rst:21

    This may make people nervous on reading. In fact, the "default" policy now kicks in if it hasn't been changed, right? That means 8 chars and some goodies? Maybe worth to rephrase here a bit?
  14. Torben Hansen uploaded patch set 5 10/12/22, 16:40

  15. Torben Hansen commented on patch set 5 10/12/22, 16:42

    Feature-97391-UsePasswordPolicyForPasswordResetInExtbackend.rst:21 Reply

    I updated the RST to list all password requirements for the TYPO3 default password policy.
  16. core-ci voted on patch set 5 V +1 10/12/22, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32253

  17. Anja Leichsenring voted on patch set 5 V +1 CR +1 10/20/22, 17:13

  18. Georg Ringer voted on patch set 5 V +2 CR +2 10/20/22, 17:49

  19. Georg Ringer merged patch set 6 10/20/22, 17:49