76077[FEATURE] Use password policy for password reset in ext:backend
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php+30 −5
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+14 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_reset_password.xlf2+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.html+8 −1
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php+1 −1
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-97391-UsePasswordPolicyForPasswordResetInExtbackend.rst2new+30 −0
Review log 1419
-
Torben Hansen uploaded patch set 1 10/10/22, 17:50
-
core-ci voted on patch set 1 V +1 10/10/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32155
-
Chris Müller uploaded patch set 2 10/10/22, 18:42
-
core-ci voted on patch set 2 V +1 10/10/22, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32156
-
Benni Mack commented on patch set 2 10/11/22, 06:39
nice job! -
Torben Hansen uploaded patch set 3 10/11/22, 16:10
-
core-ci voted on patch set 3 V +1 10/11/22, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32216
-
Georg Ringer commented on patch set 3 CR -1 10/11/22, 22:08
locallang_reset_password.xlf:13please use a different identifier because otherwise translaitons will also end in other languages and there is a different meaning -
Torben Hansen uploaded patch set 4 10/12/22, 04:17
-
Torben Hansen commented on patch set 3 10/12/22, 04:18
locallang_reset_password.xlf:13ReplyI now renamed the label identifier, since the old label is not used any more. -
core-ci voted on patch set 4 V +1 10/12/22, 04:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32233
-
Georg Ringer voted on patch set 4 V +1 CR +1 10/12/22, 07:58
-
Christian Kuhn commented on patch set 4 10/12/22, 08:03
Feature-97391-UsePasswordPolicyForPasswordResetInExtbackend.rst:21This may make people nervous on reading. In fact, the "default" policy now kicks in if it hasn't been changed, right? That means 8 chars and some goodies? Maybe worth to rephrase here a bit? -
Torben Hansen uploaded patch set 5 10/12/22, 16:40
-
Torben Hansen commented on patch set 5 10/12/22, 16:42
Feature-97391-UsePasswordPolicyForPasswordResetInExtbackend.rst:21ReplyI updated the RST to list all password requirements for the TYPO3 default password policy. -
core-ci voted on patch set 5 V +1 10/12/22, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32253
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 10/20/22, 17:13
-
Georg Ringer voted on patch set 5 V +2 CR +2 10/20/22, 17:49
-
Georg Ringer merged patch set 6 10/20/22, 17:49