Review main Merged

76081[TASK] Make TreeFromLineStreamBuilder a stateless service

Christian Kuhn CR +2 V +2 Normal +28 −38 updated 10/11/22, 06:32

Commit message

TypoScript related TreeFromLineStreamBuilder has state
due to setTokenizer(), it should be "shared: false" in DI.

We can make it stateless by avoiding the explicit
set tokenizer and turning it into a mandatory argument
of buildTree(). This makes all stateful properties
mandatory arguments of the single entry method, which
makes the class effectively stateless since all state
is set a-new with next call.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 57

  1. Christian Kuhn uploaded patch set 1 10/11/22, 03:59

  2. Christian Kuhn updated the commit message in patch set 2 10/11/22, 04:03

  3. core-ci voted on patch set 1 V +1 10/11/22, 04:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32168

  4. core-ci voted on patch set 2 V +1 10/11/22, 04:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32170

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/11/22, 06:26

  6. Benni Mack voted on patch set 2 V +2 CR +2 10/11/22, 06:32

  7. Benni Mack merged patch set 3 10/11/22, 06:32