Review main Merged

76082[BUGFIX] Clear 'setup' in 'Create empty start page' sys_template

Christian Kuhn CR +2 V +2 Normal +18 −127 updated 10/11/22, 06:28

Commit message

The installer has a step to 'Create empty start page'
which adds a default sys_template to a first page.

This sys_template should set 'clear' flag to 3 to clear
both 'constants' and 'setup', which triggers inclusion of
global TypoScript. This is the same as done in BE Template
Info module with "Create template for a new site".

While we are at it, we're streamlining the class code
a bit by removing obsolete annotations, adding some
type hints, using constructor property promotion,
and declaring this internal class final.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 10/11/22, 04:39

  2. core-ci voted on patch set 1 V +1 10/11/22, 04:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32174

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/11/22, 05:54

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/11/22, 06:28

  5. Benni Mack merged patch set 2 10/11/22, 06:28