Review main Merged

76089[TASK] Merge AbstractConfigurationManager away

Christian Kuhn CR +2 V +2 Expert +1258 −681 updated 10/11/22, 12:22

Commit message

The extbase ConfigurationManager is a complex beast full
of anti patterns. We need to refactor here to unblock
other things.

AbstractConfigurationManager is the base of the 'concrete' classes
BackendConfigurationManager and FrontendConfigurationManager. These
are @internal with ConfigurationManager being the outer API.

To reduce complexity and to allow looking at Frontend and Backend
scenarios without triggering side effects on the other one, this
divide and conquer patch simply copies all code from
AbstractConfigurationManager into the inheriting classes, making
them standalone. Existing unit tests of AbstractConfigurationManager
are also copied to the two consuming classes. No further other
refactorings are done with this patch to keep it simple.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 89

  1. Christian Kuhn uploaded patch set 1 10/11/22, 11:48

  2. core-ci voted on patch set 1 V +1 10/11/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32203

  3. Stefan Bürk voted on patch set 1 CR +1 10/11/22, 12:00

  4. Stefan Bürk voted on patch set 1 V +1 10/11/22, 12:05

  5. Georg Ringer voted on patch set 1 V +1 CR +1 10/11/22, 12:10

  6. Andreas Kienast voted on patch set 1 CR +1 10/11/22, 12:11

  7. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/11/22, 12:21

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 10/11/22, 12:22

  9. Christian Kuhn merged patch set 2 10/11/22, 12:22