Review main Merged

76090[TASK] Clean up BackendConfigurationManager

Christian Kuhn CR +2 V +2 Hard +106 −411 updated 10/11/22, 20:47

Commit message

A first code clean up of this class streamlines
the properties and removes some rather obvious
stuff. The unit tests receive an overhaul.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 57

  1. Christian Kuhn uploaded patch set 1 10/11/22, 13:58

  2. core-ci voted on patch set 1 V -1 10/11/22, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32209

  3. Christian Kuhn uploaded patch set 2 10/11/22, 16:11

  4. core-ci voted on patch set 2 V +1 10/11/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32217

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/11/22, 19:02

  6. Georg Ringer voted on patch set 2 V +2 CR +2 10/11/22, 20:47

  7. Georg Ringer merged patch set 3 10/11/22, 20:47