Review main Merged

76097[TASK] Update coding styleguide to PER + additional configs

Benni Mack CR +2 V +2 Expert +714 −703 updated 10/12/22, 10:42

Commit message

This change adapts our coding guidelines
and rules with PHP-CS-Fixer, allowing for
* PER (a.k.a. PSR-12)
* no_useless_nullsafe_operator (only use nullsafe if allowed)
* only single-spaces in arrays

This effectively adapts our code base
* use "public const" instead of "const" where visibility is not defined
* one whitespace between "declare()" and "namespace" declarations
* Use (float) instead of (double) casting
* Additional space in annonymous classes (PER)
* grouped "use" statements (classes, function, constants)
* only one space between items in array lists
* Use (bool) instead of (boolean)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 191

Show 171 more files

Review log 811

  1. Benni Mack uploaded patch set 1 10/12/22, 08:51

  2. core-ci voted on patch set 1 V +1 10/12/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32234

  3. Stefan Bürk updated the commit message in patch set 2 10/12/22, 09:14

  4. core-ci voted on patch set 2 V +1 10/12/22, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32235

  5. Benni Mack updated the commit message in patch set 3 10/12/22, 10:31

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 10/12/22, 10:33

  7. Stefan Bürk voted on patch set 3 V +2 CR +2 10/12/22, 10:37

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 10/12/22, 10:37

  9. core-ci voted on patch set 3 V +1 10/12/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32239

  10. Benni Mack voted on patch set 3 V +2 CR +2 10/12/22, 10:42

  11. Benni Mack merged patch set 4 10/12/22, 10:42