Review main Merged

76098[TASK] Centralize checkPid functionality

Benni Mack CR +2 V +2 Normal +164 −26 updated 10/21/22, 21:40

Commit message

The functionality to check authentication such
as frontend users only to certain PIDs, is now centralized
in FrontendUserAuthentication along with the logic
to use the common API with "userConstraints()" to enable
a query restriction only to certain PIDs.

This way, all restrictions are unified in the enable clause

Further refactorings could be
* use a service or event to modify the constraints in a unified way,
  or even move the constraints completely to the auth service.
* use a UserRepository that should deal with the constraints

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2736

Show 711 earlier messages
  1. Benni Mack uploaded patch set 1 10/12/22, 09:57

  2. core-ci voted on patch set 1 V -1 10/12/22, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32237

  3. Benni Mack uploaded patch set 2 10/12/22, 10:13

  4. core-ci voted on patch set 2 V -1 10/12/22, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32238

  5. Benni Mack uploaded patch set 3 10/12/22, 11:22

  6. core-ci voted on patch set 3 V -1 10/12/22, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32245

  7. Benni Mack uploaded patch set 4 10/12/22, 11:55

  8. core-ci voted on patch set 4 V +1 10/12/22, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32247

  9. Christian Kuhn commented on patch set 4 10/12/22, 12:08

    tricky. needs good reviews.
  10. Benni Mack commented on patch set 4 10/12/22, 15:47

    Reply

    not really tbh, the failing functional tests until PS3 showed a really good flaw. The rest is: Log in via FE Login and see if it works (also keep being logged in) with and without the TYPO3_CONF_VARS option.
  11. Georg Ringer commented on patch set 4 10/12/22, 17:52

    AbstractUserAuthentication.php:111

    breaking change

    AbstractUserAuthentication.php:993

    should we add true as 3rd argument?

    BackendUserAuthentication.php:176

    breaking change

    PageIdListRestriction.php:48

    why not using Connection::PARAM_INT_ARRAY?

    FrontendUserAuthentication.php:109

    breaking?
  1. Benni Mack commented on patch set 4 10/12/22, 18:37

    AbstractUserAuthentication.php:993 Reply

    at this point you don't have a connection, where you could do a createNamedParameter...
  2. Benni Mack uploaded patch set 5 10/12/22, 20:00

  3. Benni Mack uploaded patch set 6 10/12/22, 20:05

  4. Benni Mack commented on patch set 5 10/12/22, 20:05

    AbstractUserAuthentication.php:111 Reply

    Done

    AbstractUserAuthentication.php:993 Reply

    Done

    BackendUserAuthentication.php:176 Reply

    Done

    PageIdListRestriction.php:48 Reply

    at this point you don't have a connection, where you could do a createNamedParameter...

    FrontendUserAuthentication.php:109 Reply

    Done
  5. core-ci voted on patch set 5 V +1 10/12/22, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32257

  6. core-ci voted on patch set 6 V +1 10/12/22, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32258

  7. Benni Mack commented on patch set 7 10/12/22, 21:11

    Published edit on patch set 6.
  8. core-ci voted on patch set 7 V +1 10/12/22, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32259

  9. Benni Mack commented on patch set 8 10/14/22, 10:15

    Published edit on patch set 7.
  10. core-ci voted on patch set 8 V +1 10/14/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32323

  11. Andreas Kienast commented on patch set 8 10/21/22, 11:57

    PageIdListRestriction.php:26

    Should we make this internal?
  12. Benni Mack commented on patch set 8 10/21/22, 12:01

    PageIdListRestriction.php:26 Reply

    hmm, not really. I think we could start using this much more often :)
  13. Benni Mack commented on patch set 8 10/21/22, 13:44

    PageIdListRestriction.php:26 Reply

    Done
  14. Andreas Kienast voted on patch set 8 CR +1 10/21/22, 13:47

  15. Georg Ringer voted on patch set 8 V +1 CR +1 10/21/22, 19:11

  16. Christian Kuhn commented on patch set 8 10/21/22, 21:22

    PageIdListRestriction.php:26

    let's mark this final?
  17. Christian Kuhn uploaded patch set 9 10/21/22, 21:23

  18. Christian Kuhn commented on patch set 9 10/21/22, 21:23

    PageIdListRestriction.php:26 Reply

    Done
  19. Christian Kuhn uploaded patch set 10 10/21/22, 21:30

  20. Christian Kuhn uploaded patch set 11 10/21/22, 21:31

  21. core-ci voted on patch set 11 V +1 10/21/22, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32602

  22. Stefan Bürk voted on patch set 11 V +1 CR +1 10/21/22, 21:39

  23. Christian Kuhn voted on patch set 11 V +1 CR +1 10/21/22, 21:39

  24. Stefan Bürk voted on patch set 11 V +2 CR +2 10/21/22, 21:40

  25. Stefan Bürk merged patch set 12 10/21/22, 21:40