76098[TASK] Centralize checkPid functionality
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 10
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Authentication/AbstractAuthenticationService.php+0 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php5+12 −11
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+1 −0
- typo3/sysext/core/Classes/Database/Query/Restriction/PageIdListRestriction.php7new+54 −0
- typo3/sysext/core/Tests/Functional/Authentication/AuthenticationServiceTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/PageIdListRestrictionTest.phpnew+83 −0
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php2+13 −1
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+0 −6
Review log 2736
Show 711 earlier messages
-
Benni Mack uploaded patch set 1 10/12/22, 09:57
-
core-ci voted on patch set 1 V -1 10/12/22, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32237
-
Benni Mack uploaded patch set 2 10/12/22, 10:13
-
core-ci voted on patch set 2 V -1 10/12/22, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32238
-
Benni Mack uploaded patch set 3 10/12/22, 11:22
-
core-ci voted on patch set 3 V -1 10/12/22, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32245
-
Benni Mack uploaded patch set 4 10/12/22, 11:55
-
core-ci voted on patch set 4 V +1 10/12/22, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32247
-
Christian Kuhn commented on patch set 4 10/12/22, 12:08
tricky. needs good reviews. -
Benni Mack commented on patch set 4 10/12/22, 15:47
Reply
not really tbh, the failing functional tests until PS3 showed a really good flaw. The rest is: Log in via FE Login and see if it works (also keep being logged in) with and without the TYPO3_CONF_VARS option. -
Georg Ringer commented on patch set 4 10/12/22, 17:52
AbstractUserAuthentication.php:111breaking changeAbstractUserAuthentication.php:993should we add true as 3rd argument?BackendUserAuthentication.php:176breaking changePageIdListRestriction.php:48why not using Connection::PARAM_INT_ARRAY?FrontendUserAuthentication.php:109breaking?
-
Benni Mack commented on patch set 4 10/12/22, 18:37
AbstractUserAuthentication.php:993Replyat this point you don't have a connection, where you could do a createNamedParameter... -
Benni Mack uploaded patch set 5 10/12/22, 20:00
-
Benni Mack uploaded patch set 6 10/12/22, 20:05
-
Benni Mack commented on patch set 5 10/12/22, 20:05
AbstractUserAuthentication.php:111ReplyDoneAbstractUserAuthentication.php:993ReplyDoneBackendUserAuthentication.php:176ReplyDonePageIdListRestriction.php:48Replyat this point you don't have a connection, where you could do a createNamedParameter...FrontendUserAuthentication.php:109ReplyDone -
core-ci voted on patch set 5 V +1 10/12/22, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32257
-
core-ci voted on patch set 6 V +1 10/12/22, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32258
-
Benni Mack commented on patch set 7 10/12/22, 21:11
Published edit on patch set 6. -
core-ci voted on patch set 7 V +1 10/12/22, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32259
-
Benni Mack commented on patch set 8 10/14/22, 10:15
Published edit on patch set 7. -
core-ci voted on patch set 8 V +1 10/14/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32323
-
Andreas Kienast commented on patch set 8 10/21/22, 11:57
PageIdListRestriction.php:26Should we make this internal? -
Benni Mack commented on patch set 8 10/21/22, 12:01
PageIdListRestriction.php:26Replyhmm, not really. I think we could start using this much more often :) -
Benni Mack commented on patch set 8 10/21/22, 13:44
PageIdListRestriction.php:26ReplyDone -
Andreas Kienast voted on patch set 8 CR +1 10/21/22, 13:47
-
Georg Ringer voted on patch set 8 V +1 CR +1 10/21/22, 19:11
-
Christian Kuhn commented on patch set 8 10/21/22, 21:22
PageIdListRestriction.php:26let's mark this final? -
Christian Kuhn uploaded patch set 9 10/21/22, 21:23
-
Christian Kuhn commented on patch set 9 10/21/22, 21:23
PageIdListRestriction.php:26ReplyDone -
Christian Kuhn uploaded patch set 10 10/21/22, 21:30
-
Christian Kuhn uploaded patch set 11 10/21/22, 21:31
-
core-ci voted on patch set 11 V +1 10/21/22, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32602
-
Stefan Bürk voted on patch set 11 V +1 CR +1 10/21/22, 21:39
-
Christian Kuhn voted on patch set 11 V +1 CR +1 10/21/22, 21:39
-
Stefan Bürk voted on patch set 11 V +2 CR +2 10/21/22, 21:40
-
Stefan Bürk merged patch set 12 10/21/22, 21:40