Review main Merged

76099[TASK] Make TreeBuilder a stateless service

Christian Kuhn CR +2 V +2 Normal +52 −64 updated 10/12/22, 11:19

Commit message

We can avoid ugly setters in TypoScript TreeBuilder
class by handing over arguments to the main function,
effectively making this service stateless.

Especially cache and tokenizer should not be injected
since they are runtime dependencies and should be given
as arguments from controllers.

$forceProcessExtensionStatics is an extbase specific
thing kept for now, but it will be solved differently
later, when extbase BackendConfigurationManager switches
to new TypoScript parser.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 913

  1. Christian Kuhn uploaded patch set 1 10/12/22, 10:34

  2. core-ci voted on patch set 1 V +1 10/12/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32240

  3. Christian Kuhn updated the commit message in patch set 2 10/12/22, 10:46

  4. Christian Kuhn rebased onto patch set 3 10/12/22, 10:51

  5. Stefan Bürk voted on patch set 3 V +1 CR +1 10/12/22, 10:53

  6. core-ci voted on patch set 2 V +1 10/12/22, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32242

  7. core-ci voted on patch set 3 V +1 10/12/22, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32243

  8. Stefan Bürk updated the commit message in patch set 4 10/12/22, 10:59

  9. Stefan Bürk voted on patch set 4 V +1 CR +1 10/12/22, 10:59

  10. core-ci voted on patch set 4 V +1 10/12/22, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32244

  11. Benni Mack voted on patch set 4 V +1 CR +1 10/12/22, 11:17

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 10/12/22, 11:19

  13. Christian Kuhn merged patch set 5 10/12/22, 11:19