Review main Merged

76101[TASK] Remove jQuery UI components from EXT:form backend module

Andreas Kienast CR +2 V +2 Expert +144 −1077 updated 04/16/23, 13:45

Commit message

The backend module of EXT:form uses an enhanced version of jQuery UI's
sortable implementation that can handle nested sortables.

In order to get rid of jQuery (UI), SortableJS may be used instead.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1217

  1. Andreas Kienast uploaded patch set 1 10/12/22, 12:30

  2. core-ci voted on patch set 1 V +1 10/12/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32248

  3. Andreas Kienast uploaded patch set 2 10/12/22, 13:18

  4. core-ci voted on patch set 2 V +1 10/12/22, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32249

  5. Andreas Kienast uploaded patch set 3 10/12/22, 14:18

  6. core-ci voted on patch set 3 V +1 10/12/22, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32250

  7. Andreas Kienast uploaded patch set 4 10/12/22, 14:46

  8. core-ci voted on patch set 4 V +1 10/12/22, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32252

  9. Andreas Kienast uploaded patch set 5 10/13/22, 11:04

  10. core-ci voted on patch set 5 V +1 10/13/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32284

  11. Benni Mack voted on patch set 5 CR +1 10/13/22, 14:31

  12. Benni Mack voted on patch set 5 V +1 10/17/22, 18:38

  13. Stefan Bürk voted on patch set 5 V +1 CR +1 10/20/22, 05:11

  14. Andreas Kienast voted on patch set 5 V +2 CR +2 10/20/22, 05:39

  15. Andreas Kienast merged patch set 6 10/20/22, 05:39

  16. Josef Glatz commented on patch set 6 01/31/23, 06:19

    Unresolved

    Possible regression found: https://forge.typo3.org/issues/99736
  17. Christian Kuhn commented on patch set 6 04/16/23, 13:45

    there seems to be another regression: the form editor init code "sometimes" crashes with "Cannot read properties of undefined (reading 'querySelectorAll')" in stage-component line 416.