Review main Merged

76104[TASK] Add tests for GeneralUtility::implodeAttributes

Benni Mack CR +2 V +2 Normal +50 −8 updated 10/13/22, 07:48

Commit message

This change renames some variables within
GeneralUtility::implodeAttributes and adds some first
tests to this method.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 10/12/22, 21:40

  2. core-ci voted on patch set 1 V -1 10/12/22, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32261

  3. Benni Mack uploaded patch set 2 10/12/22, 21:50

  4. core-ci voted on patch set 2 V +1 10/12/22, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32262

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/13/22, 05:22

  6. Georg Ringer voted on patch set 2 V +2 CR +2 10/13/22, 07:48

  7. Georg Ringer merged patch set 3 10/13/22, 07:48