Review main Merged

76105[BUGFIX] Add missing null-checks for typoscript asset includes

Benjamin Kott CR +2 V +2 Easy +13 −3 updated 10/13/22, 11:14

Commit message

With the introduction of additional
attributes for asset includes it was not
considered that a asset can not provide
any config at all.

This patch adds the missing null checks
to resolve the issue.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1316

  1. Benjamin Kott uploaded patch set 1 10/13/22, 07:59

  2. Christian Kuhn commented on patch set 1 10/13/22, 08:02

    stumbled upon that, too, yesterday and had a similar patch in stash. benni aims to solve this as well, i think: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76103 please coordinate with him.
  3. Christian Kuhn voted on patch set 1 CR -1 10/13/22, 08:02

  4. Benjamin Kott commented on patch set 1 10/13/22, 08:04

    Reply

    ok will discard the patch and wait for bennis patch
  5. Benjamin Kott commented on patch set 1 V -1 CR -1 10/13/22, 08:05

    waiting for benni
  6. core-ci voted on patch set 1 V +1 10/13/22, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32274

  7. Benni Mack commented on patch set 1 10/13/22, 09:59

    I think this patch is good and can be merged - however, I'd like to see if I can add tests to it.
  8. Benni Mack commented on patch set 1 10/13/22, 10:04

    Great, we have a UriPrefixer Test which tests includeCSS and includeJS, both have the fallback - but the ones you fixed here, don't have that. so I will add this.
  9. Benni Mack uploaded patch set 2 10/13/22, 10:12

  10. Benni Mack voted on patch set 2 V +1 CR +1 10/13/22, 10:12

  11. Benni Mack updated the commit message in patch set 3 10/13/22, 10:13

  12. Benni Mack voted on patch set 3 V +1 CR +1 10/13/22, 10:13

  13. core-ci voted on patch set 2 V +1 10/13/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32281

  14. core-ci voted on patch set 3 V +1 10/13/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32282

  15. Andreas Kienast voted on patch set 3 V +2 CR +2 10/13/22, 11:14

  16. Andreas Kienast merged patch set 4 10/13/22, 11:14