76106[TASK] More efficient FE TypoScript cache layer
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 21
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractNode.php+22 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/ReferenceChildNode.php+9 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/RootNode.php+10 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractConditionInclude.php+3 −2
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeInterface.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionIncludeListAccumulatorVisitor.phpnew+60 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionMatcherVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/LineStream.php+12 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/AbstractTokenStream.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/IdentifierTokenStream.php+3 −2
- typo3/sysext/core/Tests/Functional/TypoScript/AST/AstBuilderInterfaceTest.php+6 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeBuilderTest.php+13 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/UnserializedIncludeTreeObjectComparator.phpnew+43 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AbstractNodeWithoutOriginalValueTokenStreamIdentifierComparator.phpnew+41 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderInterfaceTest.php+50 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/IdentifierTokenWithoutLineAndColumnComparator.phpnew+41 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php16+256 −268
- typo3/sysext/tstemplate/Classes/Controller/ObjectBrowserController.php+1 −1
Review log 3446
Show 1221 earlier messages
-
Christian Kuhn uploaded patch set 1 10/13/22, 07:59
-
Christian Kuhn commented on patch set 1 CR -1 10/13/22, 08:03
better constants caching done already, setup needs similar work. -
core-ci voted on patch set 1 V -1 10/13/22, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32275
-
Christian Kuhn uploaded patch set 2 10/14/22, 21:51
-
Christian Kuhn commented on patch set 2 CR -1 10/14/22, 22:01
better setup layer, but one level and no-cache cleanup still missing. -
core-ci voted on patch set 2 V -1 10/14/22, 22:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32348
-
Christian Kuhn uploaded patch set 3 10/19/22, 18:48
-
core-ci voted on patch set 3 V -1 10/19/22, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32474
-
Christian Kuhn uploaded patch set 4 10/19/22, 20:44
-
core-ci voted on patch set 4 V -1 10/19/22, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32475
-
Christian Kuhn uploaded patch set 5 10/20/22, 07:12
-
Christian Kuhn uploaded patch set 6 10/20/22, 07:16
-
core-ci voted on patch set 5 V +1 10/20/22, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32488
-
core-ci voted on patch set 6 V +1 10/20/22, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32489
-
Christian Kuhn uploaded patch set 7 10/20/22, 07:39
-
core-ci voted on patch set 7 V +1 10/20/22, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32492
-
Christian Kuhn uploaded patch set 8 10/20/22, 10:47
-
core-ci voted on patch set 8 V +1 10/20/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32503
-
Christian Kuhn uploaded patch set 9 10/20/22, 11:33
-
core-ci voted on patch set 9 V +1 10/20/22, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32504
-
Christian Kuhn updated the commit message in patch set 10 10/20/22, 12:16
-
Christian Kuhn uploaded patch set 11 10/20/22, 12:21
-
Christian Kuhn updated the commit message in patch set 12 10/20/22, 12:27
-
Christian Kuhn updated the commit message in patch set 13 10/20/22, 12:27
-
Benni Mack commented on patch set 13 10/20/22, 12:34
TypoScriptFrontendController.php:1265to be honest --- all of this code has to go in easily-accessible API classes. This is all up for a followup-job of course. -
core-ci voted on patch set 13 V +1 10/20/22, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32510
-
Wouter Wolters commented on patch set 13 10/20/22, 12:48
Nice work as always Christian 😊successful :) -
Christian Kuhn updated the commit message in patch set 14 10/20/22, 12:56
-
Christian Kuhn commented on patch set 14 10/20/22, 12:57
Reply
DoneTypoScriptFrontendController.php:1265Replyyeah. noted that as todo on the method already. we'll have to get rid of some tsfe-state to do this, though ... i'll mitigate this with further changes a bit, already. -
core-ci voted on patch set 14 V +1 10/20/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32512
-
Andreas Kienast commented on patch set 14 10/20/22, 13:09
TypoScriptFrontendController.php:1232Unused variable, gets overridden in line 1248TypoScriptFrontendController.php:1352Unused variable, overridden in line 1378 -
Christian Kuhn commented on patch set 14 10/20/22, 13:14
TypoScriptFrontendController.php:1232Replytrue. this is preliminary to solve a todo where we'll assign these ast's to request object. hope it's fine to keep it for this version to keep systematics intact for now.TypoScriptFrontendController.php:1352Replytrue. this is preliminary to solve a todo where we'll assign these ast's to request object. hope it's fine to keep it for this version to keep systematics intact for now. -
Andreas Kienast commented on patch set 14 V -1 10/20/22, 13:14
Something is fishy: Given: bootstrap_package installed and caches are flushed. When calling any subpage on level 2 (e.g. /pages/default), the text of the main menu is not readable. With a current "blank" main branch, this issue is gone. -
Stefan Bürk commented on patch set 14 10/20/22, 13:18
TypoScriptFrontendController.php:1232Replyno, that's not correct. L1248 is if (with L1237) no_cache === true OR !$gitConstantsFromCache this is here the part to get it from cache if !$noCache. So this is var is needed, as if this line is run, L1234 is run and L1248 not.TypoScriptFrontendController.php:1352Replyno, that's not correct. L1378 is only executed if (with L1357) no_cache === true OR !$gitConstantsFromCache this is here the part to get it from cache if !$noCache. So this is var is needed, as if this line is run, L1354 is run and 1378 not. -
Stefan Bürk commented on patch set 14 10/20/22, 13:21
TypoScriptFrontendController.php:1232ReplyPHPStorm is here wrong - or ?TypoScriptFrontendController.php:1352ReplyPHPStorm is here wrong - or ? -
Andreas Kienast commented on patch set 14 10/21/22, 06:59
TypoScriptFrontendController.php:1232Reply$constantAst is redefined within the if() block and only used there.TypoScriptFrontendController.php:1352Reply$constantAst is redefined within the if() block and only used there. -
Christian Kuhn uploaded patch set 15 10/21/22, 07:46
-
Christian Kuhn commented on patch set 15 10/21/22, 07:48
Reply
used wrong traverser for constants which basically made constant-condition-bodys being evaluated every time. fixed now and improved code comments along the way.TypoScriptFrontendController.php:1232Replyphpstorm is correct: $constantAst is *not* used, but it will be used with next patch, which is why i'd like to keep it for now.TypoScriptFrontendController.php:1352Replyphpstorm is correct here: $setupAst is not used, but it will be used with next patch, which is why i'd like to keep it for now. -
core-ci voted on patch set 15 V +1 10/21/22, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32562
-
Andreas Kienast commented on patch set 15 V +1 CR +1 10/21/22, 08:10
TypoScriptFrontendController.php:1223I love your comments 😂 -
Christian Kuhn commented on patch set 15 10/21/22, 08:11
TypoScriptFrontendController.php:1223ReplyDone -
Stefan Bürk voted on patch set 15 CR +1 10/21/22, 08:11
-
Stefan Bürk voted on patch set 15 V +1 10/21/22, 08:32
-
Anja Leichsenring voted on patch set 15 V +1 CR +1 10/21/22, 08:58
-
Christian Kuhn voted on patch set 15 V +2 CR +2 10/21/22, 10:32
-
Christian Kuhn merged patch set 16 10/21/22, 10:33