76107[BUGFIX] Assure a string is passed to `octdec` function
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1216
-
Elias Häußler uploaded patch set 1 10/13/22, 09:43
-
Elias Häußler updated the commit message in patch set 2 10/13/22, 09:45
-
core-ci voted on patch set 1 V +1 10/13/22, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32276
-
core-ci voted on patch set 2 V +1 10/13/22, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32277
-
Oliver Klee commented on patch set 2 10/13/22, 09:54
Please let's also have this for 11.5. -
Elias Häußler updated the commit message in patch set 3 10/13/22, 09:55
-
Oliver Klee commented on patch set 3 10/13/22, 09:55
GeneralUtility.php:1736Just to make this really tight, I propose we also add a string cast. (Ditto for the other place.) -
Elias Häußler commented on patch set 3 10/13/22, 09:55
Reply
Done -
Elias Häußler uploaded patch set 4 10/13/22, 09:57
-
Elias Häußler commented on patch set 4 10/13/22, 09:57
GeneralUtility.php:1736ReplyDone -
Oliver Klee voted on patch set 4 CR +1 10/13/22, 10:03
-
core-ci voted on patch set 4 V +1 10/13/22, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32279
-
core-ci voted on patch set 3 V +1 10/13/22, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32278
-
Stefan Bürk voted on patch set 4 V +1 CR +1 10/13/22, 15:09
-
Benni Mack voted on patch set 4 V +2 CR +2 10/14/22, 10:30
-
Benni Mack merged patch set 5 10/14/22, 10:30