Review main Abandoned

76117[BUGFIX] Migrate CKEditor toolbar links commands to TYPO3 link modules

Benjamin Kott CR 0 V 0 Easy +2 −2 updated 10/26/22, 08:47

Commit message

While the technical implementation and mapping were correct to
convert the old CKEditor4 link commands to the new ones in
CKEditor5, the migration failed to achieve its purpose.

The aim is to migrate the existing CKEditor TYPO3 configuration
to the new one. We now provide custom modules for link handling,
which have to be considered during the migration.

TYPO3 equivalents for CKEditor Link Modules:
- link => Typo3Link
- unlink => Typo3Unlink

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 69

  1. Benjamin Kott uploaded patch set 1 10/14/22, 11:11

  2. core-ci voted on patch set 1 V +1 10/14/22, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32327

  3. Stephan Großberndt updated the commit message in patch set 2 10/14/22, 11:34

  4. Stephan Großberndt updated the commit message in patch set 3 10/14/22, 11:35

  5. core-ci voted on patch set 2 V +1 10/14/22, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32330

  6. core-ci voted on patch set 3 V +1 10/14/22, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32331

  7. Oliver Hader commented on patch set 3 10/14/22, 14:50

    What's the current problem? `Typo3Link` and `Typo3Unlink` refers to the UI buttons, but not the commands.
  8. Benjamin Kott commented on patch set 3 10/24/22, 06:50

    Reply

    Current problem is that the current RTE configs were always referring to "links" to enable links in the RTE, since "links" is now migrated to the new CKEditor5 linking modules all existing configurations are missing the option to create or edit links. Since we are removing the link plugin and replacing it with our own but are not matching the "link" plugin name.
  9. Benjamin Kott abandoned the change 10/26/22, 08:47