76118[TASK] Refactor Backend Live Search functionality
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 36
- Build/phpstan/phpstan-baseline.neon+0 −10
- Build/Sources/Sass/component/_livesearch.scss+21 −15
- Build/Sources/TypeScript/backend/live-search/element/provider/default-result-item.tsnew+43 −0
- Build/Sources/TypeScript/backend/live-search/element/provider/page-provider-result-item.tsnew+44 −0
- Build/Sources/TypeScript/backend/live-search/element/result-container.ts+29 −12
- Build/Sources/TypeScript/backend/live-search/element/result-item.ts+8 −22
- Build/Sources/TypeScript/backend/live-search/element/search-option-item.tsnew+53 −0
- Build/Sources/TypeScript/backend/live-search/result-types/page-result-type.tsnew+15 −0
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+80 −56
- typo3/sysext/backend/Classes/Controller/BackendController.php+2 −0
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+56 −21
- typo3/sysext/backend/Classes/EventListener/AfterBackendPageRenderEventListener.phpnew+41 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.phpnew+369 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.phpdeleted+0 −464
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.phpnew+370 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/QueryParser.php+2 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/ResultItem.phpnew+90 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchDemand.phpnew+48 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchProviderInterface.phpnew+33 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchProviderRegistry.phpnew+49 −0
Show 16 more files
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+9 −3
- typo3/sysext/backend/Configuration/Services.php+2 −0
- typo3/sysext/backend/Configuration/Services.yaml3+19 −2
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+12 −0
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+2 −1
- typo3/sysext/backend/Resources/Private/Templates/LiveSearch/Form.htmlnew+40 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/LiveSearchToolbarItem.html+1 −5
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/provider/default-result-item.jsnew+23 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/provider/page-provider-result-item.jsnew+24 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result-container.js+11 −9
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result-item.js+1 −11
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/search-option-item.jsnew+20 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/result-types/page-result-type.jsnew+18 −0
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −16
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/SearchCest.php+1 −1
Review log 4272
Show 2547 earlier messages
-
Andreas Kienast uploaded patch set 1 10/14/22, 12:40
-
core-ci voted on patch set 1 V -1 10/14/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32335
-
Andreas Kienast uploaded patch set 2 10/14/22, 13:42
-
core-ci voted on patch set 2 V -1 10/14/22, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32338
-
Andreas Kienast uploaded patch set 3 10/18/22, 07:52
-
core-ci voted on patch set 3 V -1 10/18/22, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32416
-
Andreas Kienast uploaded patch set 4 10/18/22, 08:52
-
core-ci voted on patch set 4 V -1 10/18/22, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32423
-
Andreas Kienast uploaded patch set 5 10/18/22, 10:17
-
core-ci voted on patch set 5 V -1 10/18/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32427
-
Andreas Kienast uploaded patch set 6 10/18/22, 10:47
-
core-ci voted on patch set 6 V -1 10/18/22, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32430
-
Andreas Kienast uploaded patch set 7 10/18/22, 11:33
-
core-ci voted on patch set 7 V +1 10/18/22, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32433
-
Andreas Kienast uploaded patch set 8 10/18/22, 14:14
-
Andreas Kienast uploaded patch set 9 10/18/22, 14:17
-
core-ci voted on patch set 8 V -1 10/18/22, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32435
-
core-ci voted on patch set 9 V -1 10/18/22, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32436
-
Andreas Kienast uploaded patch set 10 10/18/22, 15:42
-
Andreas Kienast uploaded patch set 11 10/18/22, 15:43
-
Andreas Kienast uploaded patch set 12 10/18/22, 15:46
-
core-ci voted on patch set 11 V +1 10/18/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32438
-
core-ci voted on patch set 10 V -1 10/18/22, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32437
-
core-ci voted on patch set 12 V +1 10/18/22, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32439
-
Andreas Kienast uploaded patch set 13 10/20/22, 08:17
-
Andreas Kienast uploaded patch set 14 10/20/22, 08:21
-
core-ci voted on patch set 13 V -1 10/20/22, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32494
-
core-ci voted on patch set 14 V -1 10/20/22, 08:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32495
-
Andreas Kienast uploaded patch set 15 10/20/22, 08:50
-
core-ci voted on patch set 15 V +1 10/20/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32498
-
Andreas Kienast commented on patch set 15 CR -1 10/20/22, 09:12
Need to check something -
Andreas Kienast uploaded patch set 16 10/20/22, 09:26
-
Andreas Kienast uploaded patch set 17 10/20/22, 09:28
-
core-ci voted on patch set 16 V -1 10/20/22, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32500
-
core-ci voted on patch set 17 V -1 10/20/22, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32501
-
Andreas Kienast uploaded patch set 18 10/20/22, 09:56
-
core-ci voted on patch set 18 V +1 10/20/22, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32502
-
Andreas Kienast updated the commit message in patch set 19 10/20/22, 12:49
-
core-ci voted on patch set 19 V +1 10/20/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32511
-
Benni Mack uploaded patch set 20 10/20/22, 13:55
-
Benni Mack voted on patch set 20 V +1 10/20/22, 13:55
-
core-ci voted on patch set 20 V +1 10/20/22, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32514
-
Benni Mack voted on patch set 20 CR +1 10/20/22, 15:03
-
Andreas Kienast uploaded patch set 21 10/21/22, 19:31
-
core-ci voted on patch set 21 V +1 10/21/22, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32598
-
Andreas Kienast uploaded patch set 22 10/24/22, 17:30
-
core-ci voted on patch set 22 V +1 10/24/22, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32707
-
Andreas Kienast commented on patch set 22 V -1 10/25/22, 15:01
Multiple issues: * the initial empty search always says "no results" * search options are stored in the session storage but not used for filtering when opening the modal again -
Andreas Kienast uploaded patch set 23 10/25/22, 15:11
-
core-ci voted on patch set 23 V +1 10/25/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32748
-
Andreas Kienast commented on patch set 23 CR -2 10/26/22, 10:10
working on the renderer registration -
Andreas Kienast uploaded patch set 24 10/26/22, 12:28
-
Andreas Kienast uploaded patch set 25 10/26/22, 12:32
-
Andreas Kienast uploaded patch set 26 10/26/22, 12:34
-
core-ci voted on patch set 24 V +1 10/26/22, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32800
-
Andreas Kienast voted on patch set 26 CR 0 10/26/22, 12:40
-
core-ci voted on patch set 26 V +1 10/26/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32802
-
core-ci voted on patch set 25 V +1 10/26/22, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32801
-
Andreas Kienast uploaded patch set 27 10/26/22, 12:45
-
core-ci voted on patch set 27 V +1 10/26/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32803
-
Benni Mack commented on patch set 27 10/27/22, 08:47
Services.yaml:74Do we need this? -
Andreas Kienast commented on patch set 27 CR -1 10/27/22, 10:26
Services.yaml:74ReplyGood catch. The class doesn't exist anymore, so this should get removed. -
Andreas Kienast uploaded patch set 28 10/27/22, 10:40
-
Andreas Kienast commented on patch set 28 10/27/22, 10:46
Services.yaml:74ReplyDone -
Andreas Kienast uploaded patch set 29 10/27/22, 10:48
-
core-ci voted on patch set 28 V +1 10/27/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32834
-
core-ci voted on patch set 29 V +1 10/27/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32835
-
Andreas Kienast uploaded patch set 30 10/28/22, 18:18
-
core-ci voted on patch set 30 V +1 10/28/22, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32875
-
Georg Ringer voted on patch set 30 V +1 CR +1 11/03/22, 14:31
-
Benni Mack voted on patch set 30 V +2 CR +2 11/03/22, 14:48
-
Benni Mack merged patch set 31 11/03/22, 14:48