Review main Merged

76118[TASK] Refactor Backend Live Search functionality

Andreas Kienast CR +2 V +2 Expert +1538 −650 updated 11/03/22, 14:48

Commit message

The backend search (aka Live Search) can search for database
records only, currently.

To make the search able to find anything other than database records a
`SearchProviderInterface` is introduced which allows to add new providers
in the future and may be used by extension authors in the long run.

As the first implementations, the current database record search is
extracted into a `DatabaseRecordProvider`, which excludes records from
the `pages` table. Additionally, a new `PageRecordProvider` is added
which comes with a custom web component that renders additional
information for pages only.

The changes introduced in this patch are not final and may change in
further iterations, therefore all interfaces are declared as "internal"
and documentation is missing on purpose.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 36

Show 16 more files

Review log 4272

Show 2547 earlier messages
  1. Andreas Kienast uploaded patch set 1 10/14/22, 12:40

  2. core-ci voted on patch set 1 V -1 10/14/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32335

  3. Andreas Kienast uploaded patch set 2 10/14/22, 13:42

  4. core-ci voted on patch set 2 V -1 10/14/22, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32338

  5. Andreas Kienast uploaded patch set 3 10/18/22, 07:52

  6. core-ci voted on patch set 3 V -1 10/18/22, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32416

  7. Andreas Kienast uploaded patch set 4 10/18/22, 08:52

  8. core-ci voted on patch set 4 V -1 10/18/22, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32423

  9. Andreas Kienast uploaded patch set 5 10/18/22, 10:17

  10. core-ci voted on patch set 5 V -1 10/18/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32427

  11. Andreas Kienast uploaded patch set 6 10/18/22, 10:47

  12. core-ci voted on patch set 6 V -1 10/18/22, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32430

  13. Andreas Kienast uploaded patch set 7 10/18/22, 11:33

  14. core-ci voted on patch set 7 V +1 10/18/22, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32433

  15. Andreas Kienast uploaded patch set 8 10/18/22, 14:14

  16. Andreas Kienast uploaded patch set 9 10/18/22, 14:17

  17. core-ci voted on patch set 8 V -1 10/18/22, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32435

  18. core-ci voted on patch set 9 V -1 10/18/22, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32436

  19. Andreas Kienast uploaded patch set 10 10/18/22, 15:42

  20. Andreas Kienast uploaded patch set 11 10/18/22, 15:43

  21. Andreas Kienast uploaded patch set 12 10/18/22, 15:46

  22. core-ci voted on patch set 11 V +1 10/18/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32438

  23. core-ci voted on patch set 10 V -1 10/18/22, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32437

  24. core-ci voted on patch set 12 V +1 10/18/22, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32439

  25. Andreas Kienast uploaded patch set 13 10/20/22, 08:17

  26. Andreas Kienast uploaded patch set 14 10/20/22, 08:21

  27. core-ci voted on patch set 13 V -1 10/20/22, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32494

  28. core-ci voted on patch set 14 V -1 10/20/22, 08:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32495

  29. Andreas Kienast uploaded patch set 15 10/20/22, 08:50

  30. core-ci voted on patch set 15 V +1 10/20/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32498

  31. Andreas Kienast commented on patch set 15 CR -1 10/20/22, 09:12

    Need to check something
  32. Andreas Kienast uploaded patch set 16 10/20/22, 09:26

  33. Andreas Kienast uploaded patch set 17 10/20/22, 09:28

  34. core-ci voted on patch set 16 V -1 10/20/22, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32500

  35. core-ci voted on patch set 17 V -1 10/20/22, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32501

  36. Andreas Kienast uploaded patch set 18 10/20/22, 09:56

  37. core-ci voted on patch set 18 V +1 10/20/22, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32502

  38. Andreas Kienast updated the commit message in patch set 19 10/20/22, 12:49

  39. core-ci voted on patch set 19 V +1 10/20/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32511

  40. Benni Mack uploaded patch set 20 10/20/22, 13:55

  41. Benni Mack voted on patch set 20 V +1 10/20/22, 13:55

  42. core-ci voted on patch set 20 V +1 10/20/22, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32514

  43. Benni Mack voted on patch set 20 CR +1 10/20/22, 15:03

  44. Andreas Kienast uploaded patch set 21 10/21/22, 19:31

  45. core-ci voted on patch set 21 V +1 10/21/22, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32598

  46. Andreas Kienast uploaded patch set 22 10/24/22, 17:30

  47. core-ci voted on patch set 22 V +1 10/24/22, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32707

  1. Andreas Kienast commented on patch set 22 V -1 10/25/22, 15:01

    Multiple issues: * the initial empty search always says "no results" * search options are stored in the session storage but not used for filtering when opening the modal again
  2. Andreas Kienast uploaded patch set 23 10/25/22, 15:11

  3. core-ci voted on patch set 23 V +1 10/25/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32748

  4. Andreas Kienast commented on patch set 23 CR -2 10/26/22, 10:10

    working on the renderer registration
  5. Andreas Kienast uploaded patch set 24 10/26/22, 12:28

  6. Andreas Kienast uploaded patch set 25 10/26/22, 12:32

  7. Andreas Kienast uploaded patch set 26 10/26/22, 12:34

  8. core-ci voted on patch set 24 V +1 10/26/22, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32800

  9. Andreas Kienast voted on patch set 26 CR 0 10/26/22, 12:40

  10. core-ci voted on patch set 26 V +1 10/26/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32802

  11. core-ci voted on patch set 25 V +1 10/26/22, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32801

  12. Andreas Kienast uploaded patch set 27 10/26/22, 12:45

  13. core-ci voted on patch set 27 V +1 10/26/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32803

  14. Benni Mack commented on patch set 27 10/27/22, 08:47

    Services.yaml:74

    Do we need this?
  15. Andreas Kienast commented on patch set 27 CR -1 10/27/22, 10:26

    Services.yaml:74 Reply

    Good catch. The class doesn't exist anymore, so this should get removed.
  16. Andreas Kienast uploaded patch set 28 10/27/22, 10:40

  17. Andreas Kienast commented on patch set 28 10/27/22, 10:46

    Services.yaml:74 Reply

    Done
  18. Andreas Kienast uploaded patch set 29 10/27/22, 10:48

  19. core-ci voted on patch set 28 V +1 10/27/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32834

  20. core-ci voted on patch set 29 V +1 10/27/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32835

  21. Andreas Kienast uploaded patch set 30 10/28/22, 18:18

  22. core-ci voted on patch set 30 V +1 10/28/22, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32875

  23. Georg Ringer voted on patch set 30 V +1 CR +1 11/03/22, 14:31

  24. Benni Mack voted on patch set 30 V +2 CR +2 11/03/22, 14:48

  25. Benni Mack merged patch set 31 11/03/22, 14:48