Review main Merged

76119[BUGFIX] Avoid undefined array key in FlexFormTools

Johannes Przymusinski CR +2 V +2 Easy +1 −1 updated 10/14/22, 22:00

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Johannes Przymusinski uploaded patch set 1 10/14/22, 13:21

  2. Benni Mack updated the commit message in patch set 2 10/14/22, 13:26

  3. core-ci voted on patch set 1 V +1 10/14/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32336

  4. core-ci voted on patch set 2 V +1 10/14/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32337

  5. Chris Müller voted on patch set 2 CR +1 10/14/22, 13:37

  6. Oliver Klee commented on patch set 2 10/14/22, 13:50

    FlexFormTools.php:800

    If I read the code correctly, this already is check by the isset. Or am I missing something here?
  7. Stefan Bürk commented on patch set 2 CR -1 10/14/22, 15:35

    FlexFormTools.php:800 Reply

    That was my bad in the forge issue ... I provided the "wrong" Line number for main branch to solve it. On it, will push the correct place/fix in the correct line number .....should have been L769 and not L800 ....
  8. Stefan Bürk uploaded patch set 3 10/14/22, 15:45

  9. core-ci voted on patch set 3 V +1 10/14/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32344

  10. Stefan Bürk commented on patch set 3 V +1 CR +1 10/14/22, 16:01

    FlexFormTools.php:800 Reply

    Done
  11. Oliver Klee voted on patch set 3 CR +1 10/14/22, 16:14

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 10/14/22, 21:34

  13. Stefan Bürk voted on patch set 3 V +2 CR +2 10/14/22, 22:00

  14. Stefan Bürk merged patch set 4 10/14/22, 22:00