Review main Merged

76120[TASK] Add service to prepare CSS for SCSS parsing

Frank Nägler CR +2 V +2 Hard +403 −21 updated 10/18/22, 07:56

Commit message

Add a dedicated service to parse and prepare CSS for SCSS parsing.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2532

Show 57 earlier messages
  1. Frank Nägler uploaded patch set 1 10/14/22, 13:47

  2. Frank Nägler marked it work in progress 10/14/22, 13:47

  3. core-ci voted on patch set 1 V -1 10/14/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32339

  4. Frank Nägler uploaded patch set 2 10/14/22, 14:22

  5. core-ci voted on patch set 2 V +1 10/14/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32340

  6. Frank Nägler uploaded patch set 3 10/14/22, 14:36

  7. Frank Nägler marked it ready for review 10/14/22, 14:38

  1. core-ci voted on patch set 3 V +1 10/14/22, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32341

  2. Oliver Hader commented on patch set 3 CR -1 10/17/22, 09:29

    On it..
  3. Oliver Hader uploaded patch set 4 10/17/22, 12:25

  4. Oliver Hader voted on patch set 4 V +1 CR +1 10/17/22, 12:27

  5. Andreas Kienast commented on patch set 4 10/17/22, 12:31

    fixed.scss:21

    This looks weird, is this valid CSS?
  6. Oliver Hader uploaded patch set 5 10/17/22, 12:35

  7. Oliver Hader voted on patch set 5 V +1 CR +1 10/17/22, 12:36

  8. core-ci voted on patch set 4 V -1 10/17/22, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32387

  9. Oliver Hader uploaded patch set 6 10/17/22, 12:41

  10. Oliver Hader commented on patch set 6 V +1 CR +1 10/17/22, 12:43

    fixed.scss:21 Reply

    Works & SCSS compiler strips that... I've added an additional `compiled.css` fixture as test case.
  11. Andreas Kienast commented on patch set 6 CR +1 10/17/22, 12:46

    fixed.scss:21 Reply

    Cool, thx!
  12. core-ci voted on patch set 5 V -1 10/17/22, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32388

  13. core-ci voted on patch set 6 V -1 10/17/22, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32389

  14. Andreas Kienast commented on patch set 6 CR 0 10/17/22, 12:57

    phpstan fails with PHPDoc tag @throws with type ScssPhp\ScssPhp\Exception\SassException is not subtype of Throwable which is indeed correct...
  15. Oliver Hader uploaded patch set 7 10/17/22, 13:04

  16. Oliver Hader voted on patch set 7 V +1 CR +1 10/17/22, 13:05

  17. core-ci voted on patch set 7 V +1 10/17/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32390

  18. Andreas Kienast voted on patch set 7 V +2 CR +2 10/17/22, 13:15

  19. Andreas Kienast merged patch set 8 10/17/22, 13:15

  20. Christian Kuhn commented on patch set 8 10/17/22, 17:29

    Services.yaml:16 Unresolved

    controllers usually don't need to be public?

    Services.yaml:20

    when services are injected-only, they don't need to be public? why are they set to public here? could we remove this? if not, add a comment why they're public?

    Services.yaml:24

    when services are injected-only, they don't need to be public? why are they set to public here? could we remove this? if not, add a comment why they're public?
  21. Benni Mack commented on patch set 8 10/17/22, 21:24

    Services.yaml:20 Reply

    agreed. both not needed.

    Services.yaml:24 Reply Unresolved

    main problem here is that it's not in the namespace. but does not need to be public IMHO.
  22. Oliver Hader commented on patch set 8 10/17/22, 21:46

    Post -1: Actually I does not work at all with these late dependency injection things...
  23. Oliver Hader commented on patch set 8 10/17/22, 21:56

  24. Frank Nägler commented on patch set 8 10/18/22, 06:29

    Services.yaml:20 Reply

    As I build the patch, DI was not working without the public: true. But I had the same feeling "it is wrong". Anyway, the patch goes in while I was on the road, but I am fine to change/fix it.
  25. Benni Mack commented on patch set 8 10/18/22, 07:56

    Services.yaml:20 Reply

    @Frank - no worries. Olly's latest PS broke it.