76120[TASK] Add service to prepare CSS for SCSS parsing
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/rte_ckeditor/Classes/Controller/ResourceController.php+8 −21
- typo3/sysext/rte_ckeditor/Classes/Service/ScssProcessor.phpnew+73 −0
- typo3/sysext/rte_ckeditor/Configuration/Services.yaml7+11 −0
- typo3/sysext/rte_ckeditor/Tests/Unit/Fixtures/compiled.cssnew+95 −0
- typo3/sysext/rte_ckeditor/Tests/Unit/Fixtures/fixed.scss3new+65 −0
- typo3/sysext/rte_ckeditor/Tests/Unit/Fixtures/origin.scssnew+62 −0
- typo3/sysext/rte_ckeditor/Tests/Unit/Service/ScssProcessorTest.phpnew+89 −0
Review log 2532
Show 57 earlier messages
-
Frank Nägler uploaded patch set 1 10/14/22, 13:47
-
Frank Nägler marked it work in progress 10/14/22, 13:47
-
core-ci voted on patch set 1 V -1 10/14/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32339
-
Frank Nägler uploaded patch set 2 10/14/22, 14:22
-
core-ci voted on patch set 2 V +1 10/14/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32340
-
Frank Nägler uploaded patch set 3 10/14/22, 14:36
-
Frank Nägler marked it ready for review 10/14/22, 14:38
-
core-ci voted on patch set 3 V +1 10/14/22, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32341
-
Oliver Hader commented on patch set 3 CR -1 10/17/22, 09:29
On it.. -
Oliver Hader uploaded patch set 4 10/17/22, 12:25
-
Oliver Hader voted on patch set 4 V +1 CR +1 10/17/22, 12:27
-
Andreas Kienast commented on patch set 4 10/17/22, 12:31
fixed.scss:21This looks weird, is this valid CSS? -
Oliver Hader uploaded patch set 5 10/17/22, 12:35
-
Oliver Hader voted on patch set 5 V +1 CR +1 10/17/22, 12:36
-
core-ci voted on patch set 4 V -1 10/17/22, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32387
-
Oliver Hader uploaded patch set 6 10/17/22, 12:41
-
Oliver Hader commented on patch set 6 V +1 CR +1 10/17/22, 12:43
fixed.scss:21ReplyWorks & SCSS compiler strips that... I've added an additional `compiled.css` fixture as test case. -
Andreas Kienast commented on patch set 6 CR +1 10/17/22, 12:46
fixed.scss:21ReplyCool, thx! -
core-ci voted on patch set 5 V -1 10/17/22, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32388
-
core-ci voted on patch set 6 V -1 10/17/22, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32389
-
Andreas Kienast commented on patch set 6 CR 0 10/17/22, 12:57
phpstan fails with PHPDoc tag @throws with type ScssPhp\ScssPhp\Exception\SassException is not subtype of Throwable which is indeed correct... -
Oliver Hader uploaded patch set 7 10/17/22, 13:04
-
Oliver Hader voted on patch set 7 V +1 CR +1 10/17/22, 13:05
-
core-ci voted on patch set 7 V +1 10/17/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32390
-
Andreas Kienast voted on patch set 7 V +2 CR +2 10/17/22, 13:15
-
Andreas Kienast merged patch set 8 10/17/22, 13:15
-
Christian Kuhn commented on patch set 8 10/17/22, 17:29
Services.yaml:16Unresolvedcontrollers usually don't need to be public?Services.yaml:20when services are injected-only, they don't need to be public? why are they set to public here? could we remove this? if not, add a comment why they're public?Services.yaml:24when services are injected-only, they don't need to be public? why are they set to public here? could we remove this? if not, add a comment why they're public? -
Benni Mack commented on patch set 8 10/17/22, 21:24
Services.yaml:20Replyagreed. both not needed.Services.yaml:24Reply Unresolvedmain problem here is that it's not in the namespace. but does not need to be public IMHO. -
Oliver Hader commented on patch set 8 10/17/22, 21:46
Post -1: Actually I does not work at all with these late dependency injection things... -
Oliver Hader commented on patch set 8 10/17/22, 21:56
-
Frank Nägler commented on patch set 8 10/18/22, 06:29
Services.yaml:20ReplyAs I build the patch, DI was not working without the public: true. But I had the same feeling "it is wrong". Anyway, the patch goes in while I was on the road, but I am fine to change/fix it. -
Benni Mack commented on patch set 8 10/18/22, 07:56
Services.yaml:20Reply@Frank - no worries. Olly's latest PS broke it.