Review main Merged

76121[BUGFIX] Use local TypoScriptFrontendController in nested ContentObjects

Andreas Kießling CR +2 V +2 Easy +2 −2 updated 10/20/22, 18:43

Commit message

RecordsContentObject and ContentContentObject create new instances of
the ContentObjectRenderer. They need to pass down their local instance
of the TypoScriptFrontendController so it will not try to fall back
the global instance, e.g. while indexing with EXT:solr.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Andreas Kießling uploaded patch set 1 10/14/22, 14:41

  2. core-ci voted on patch set 1 V +1 10/14/22, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32342

  3. Oliver Klee updated the commit message in patch set 2 10/14/22, 15:38

  4. core-ci voted on patch set 2 V +1 10/14/22, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32343

  5. Georg Ringer voted on patch set 2 CR +1 10/14/22, 19:29

  6. Benni Mack voted on patch set 2 V +1 CR +1 10/16/22, 18:00

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 10/20/22, 18:42

  8. Stefan Bürk merged patch set 3 10/20/22, 18:43