Review main Merged

76123[BUGFIX] Filter if conditions before creating tags in PageRenderer

Oliver Hader CR +2 V +2 Easy +4 −0 updated 10/17/22, 11:32

Commit message

Issue #91499 allows to define arbitrary HTML attributes for the
corresponding HTML tag to be generated in PageRenderer. TypoScript
`if.` conditions (array type) need to be filtered out.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Oliver Hader uploaded patch set 1 10/16/22, 09:53

  2. core-ci voted on patch set 1 V +1 10/16/22, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32360

  3. Christian Kuhn updated the commit message in patch set 2 10/16/22, 12:16

  4. core-ci voted on patch set 2 V +1 10/16/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32362

  5. Benni Mack voted on patch set 2 V +1 CR +1 10/16/22, 17:59

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 10/17/22, 11:32

  7. Andreas Kienast merged patch set 3 10/17/22, 11:32