Review main Merged

76124[BUGFIX] Use proper inline argument assignment in Fluid template

Oliver Hader CR +2 V +2 Easy +1 −1 updated 10/17/22, 05:51

Commit message

A superfluous space character in a frontend login template
leads to an exception during the Fluid parsing process.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Sebastian Michaelsen +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Sebastian Michaelsen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oliver Hader uploaded patch set 1 10/16/22, 10:08

  2. Sebastian Michaelsen voted on patch set 1 V +1 CR +1 10/16/22, 10:13

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/16/22, 10:16

  4. core-ci voted on patch set 1 V +1 10/16/22, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32361

  5. Anja Leichsenring merged patch set 2 10/16/22, 10:17

  6. Stefan Bürk commented on patch set 2 10/17/22, 01:33

    I would say, we should report/create an issue in fluid directly for this - or not ?
  7. Christian Kuhn commented on patch set 2 10/17/22, 05:51

    Reply

    yes.