76126[TASK] Increase testing coverage against PHP8.2
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
Review log 1521
-
Stefan Bürk uploaded patch set 1 10/16/22, 19:32
-
Stefan Bürk updated the commit message in patch set 2 10/16/22, 19:34
-
Stefan Bürk uploaded patch set 3 10/16/22, 19:38
-
core-ci voted on patch set 3 V -1 10/16/22, 19:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32367
-
Stefan Bürk uploaded patch set 4 10/16/22, 19:48
-
core-ci voted on patch set 4 V +1 10/16/22, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32368
-
Stefan Bürk commented on patch set 4 10/16/22, 19:58
Running nightly on changes: https://git.typo3.org/typo3/CI/cms/-/pipelines/32369 -
core-ci commented on patch set 4 10/16/22, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32369
-
Stefan Bürk uploaded patch set 5 10/16/22, 20:23
-
core-ci voted on patch set 5 V +1 10/16/22, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32370
-
Stefan Bürk commented on patch set 5 10/16/22, 20:32
rerun nightly: https://git.typo3.org/typo3/CI/cms/-/pipelines/32371 -
core-ci commented on patch set 5 10/16/22, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32371
-
Stefan Bürk updated the commit message in patch set 6 10/16/22, 21:03
-
core-ci voted on patch set 6 V +1 10/16/22, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32373
-
Oliver Klee commented on patch set 6 10/16/22, 21:47
docker-compose.yml:755I'd like to propose a less "dangerous" workaround: Fake the PHP version for Composer to 8.1 if we're on 8.2: composer config platform.php 8.1.99 This at least will avoid packages that support e.g., only PHP up to 8.0. -
Stefan Bürk commented on patch set 6 10/16/22, 21:58
docker-compose.yml:755ReplyNope, using platform 8.1.99 would make the "composer max test" kind of superflous. Using the platform will not rertieve package version which starts to have only "^8.2" as constraints, this eventually not getting the latest version. I w'd postulate using platform 8.1.99 is "more" dangerous in this regard. The goal of using the ignore platform will only allow packages to be installed with higher php version than in the constraint - and it's just a temporarly solution because of the unwillingnes of prophecy to remove the < 8.2 constraint. Both variants are not fully satisfying - I'm still more for the ignore-platform here as it will not render the max testing superflous like the platform variant. Granted, it would fail for packages not available for 8.1 - but that would be also failed on lock tests as we have alread min 8.1 requirement. Thus current solution is the better one. -
Stefan Bürk commented on patch set 6 10/16/22, 22:00
docker-compose.yml:755Replypackages php < 8.1 are already covered by locked and normal composer install tests, in pre-merge already. -
Stefan Bürk commented on patch set 6 10/17/22, 00:53
docker-compose.yml:755ReplyDone -
Benni Mack voted on patch set 6 V +1 CR +1 10/17/22, 21:37
-
Georg Ringer voted on patch set 6 V +2 CR +2 10/18/22, 07:06
-
Georg Ringer merged patch set 7 10/18/22, 07:06