Review main Merged

76129[TASK] Streamline workspaces menu and backend header styling

Andreas Kienast CR +2 V +2 Normal +26 −61 updated 10/18/22, 07:35

Commit message

The active state in the workspaces menu is now streamlined and aligned
to the look the "Help" menu by removing the "tick" icon from the active
workspace and applying a blue-ish background instead.

The workspace indicator identified by the green background color is now
applied on compile time of the Fluid template. The toolbar item template
is adjusted to optionally support a `name` attribute, used to render the
workspace title compile time.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 69

  1. Andreas Kienast uploaded patch set 1 10/17/22, 13:59

  2. Andreas Kienast uploaded patch set 2 10/17/22, 14:00

  3. core-ci voted on patch set 2 V -1 10/17/22, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32392

  4. Andreas Kienast uploaded patch set 3 10/17/22, 14:21

  5. core-ci voted on patch set 1 V -1 10/17/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32391

  6. core-ci voted on patch set 3 V +1 10/17/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32395

  7. Benni Mack voted on patch set 3 V +1 CR +1 10/17/22, 18:44

  8. Georg Ringer voted on patch set 3 V +2 CR +2 10/18/22, 07:35

  9. Georg Ringer merged patch set 4 10/18/22, 07:35