Review main Merged

76130[TASK] Make FormProtectionFactory injectable - part 2

Benni Mack CR +2 V +2 Hard +314 −186 updated 10/31/22, 09:08

Commit message

This change modifies all places in TYPO3 Core
to avoid using FormProtectionFactory::get() and use
proper DI. A new method
FormProtectionFactory->createForType(string $type)
is added.

In addition, FormProtectionFactory::set is removed
as all affected tests are moved towards injection.

The next step in this series is to deprecate the
::get() method and make a singleton out of the Factory to avoid
purgeInstances() calls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 2133

Show 48 earlier messages
  1. Benni Mack uploaded patch set 1 10/17/22, 15:49

  2. core-ci voted on patch set 1 V -1 10/17/22, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32401

  3. Benni Mack rebased onto patch set 2 10/20/22, 14:12

  4. core-ci voted on patch set 2 V -1 10/20/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32516

  5. Benni Mack uploaded patch set 3 10/20/22, 14:58

  6. core-ci voted on patch set 3 V -1 10/20/22, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32519

  7. Benni Mack uploaded patch set 4 10/20/22, 15:25

  8. core-ci voted on patch set 4 V -1 10/20/22, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32520

  1. Benni Mack uploaded patch set 5 10/20/22, 18:01

  2. core-ci voted on patch set 5 V -1 10/20/22, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32522

  3. Benni Mack uploaded patch set 6 10/20/22, 18:17

  4. core-ci voted on patch set 6 V -1 10/20/22, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32523

  5. Benni Mack uploaded patch set 7 10/20/22, 18:28

  6. core-ci voted on patch set 7 V -1 10/20/22, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32525

  7. Benni Mack uploaded patch set 8 10/20/22, 19:04

  8. core-ci voted on patch set 8 V +1 10/20/22, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32529

  9. Benni Mack uploaded patch set 9 10/21/22, 14:15

  10. core-ci voted on patch set 9 V +1 10/21/22, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32587

  11. Christian Kuhn commented on patch set 9 10/21/22, 21:52

    FormProtectionFactory.php:59

    however what?
  12. Benni Mack commented on patch set 10 10/22/22, 09:07

    Published edit on patch set 9.
  13. Benni Mack commented on patch set 10 10/22/22, 09:07

    FormProtectionFactory.php:59 Reply

    thx. fixed.
  14. core-ci voted on patch set 10 V +1 10/22/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32617

  15. Andreas Kienast commented on patch set 10 10/26/22, 08:39

    LoginController.php:116

    Is "readonly" missing on purpose?

    FormProtectionFactory.php:326

    Why not self::$instances = []?
  16. Benni Mack uploaded patch set 11 10/28/22, 20:00

  17. Benni Mack commented on patch set 11 10/28/22, 20:01

    LoginController.php:116 Reply

    Done

    FormProtectionFactory.php:326 Reply

    Done
  18. core-ci voted on patch set 11 V -1 10/28/22, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32876

  19. Benni Mack uploaded patch set 12 10/28/22, 20:58

  20. core-ci voted on patch set 12 V +1 10/28/22, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32877

  21. Georg Ringer voted on patch set 12 V +1 CR +1 10/29/22, 16:40

  22. Nikita Hovratov voted on patch set 12 CR +1 10/29/22, 18:56

  23. Nikita Hovratov voted on patch set 12 V +1 10/29/22, 21:43

  24. Benni Mack voted on patch set 12 V +2 CR +2 10/31/22, 09:08

  25. Benni Mack merged patch set 13 10/31/22, 09:08