76130[TASK] Make FormProtectionFactory injectable - part 2
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 22
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+6 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php2+3 −2
- typo3/sysext/backend/Classes/Controller/LogoutController.php+10 −5
- typo3/sysext/backend/Classes/Http/RouteDispatcher.php+10 −12
- typo3/sysext/backend/Classes/Routing/UriBuilder.php+3 −2
- typo3/sysext/backend/Classes/ServiceProvider.php+3 −2
- typo3/sysext/backend/Configuration/Services.yaml+6 −0
- typo3/sysext/backend/Tests/Unit/Controller/LoginControllerTest.php+31 −49
- typo3/sysext/backend/Tests/Unit/Http/RouteDispatcherTest.php+26 −17
- typo3/sysext/backend/Tests/Unit/Routing/UriBuilderTest.php+9 −2
- typo3/sysext/backend/Tests/Unit/View/ArrayBrowserTest.php+8 −2
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php4+59 −42
- typo3/sysext/core/Classes/ServiceProvider.php+9 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+11 −12
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+99 −12
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+5 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/LinkViewHelperTest.php+5 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/UriViewHelperTest.php+5 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+0 −7
Review log 2133
Show 48 earlier messages
-
Benni Mack uploaded patch set 1 10/17/22, 15:49
-
core-ci voted on patch set 1 V -1 10/17/22, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32401
-
Benni Mack rebased onto patch set 2 10/20/22, 14:12
-
core-ci voted on patch set 2 V -1 10/20/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32516
-
Benni Mack uploaded patch set 3 10/20/22, 14:58
-
core-ci voted on patch set 3 V -1 10/20/22, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32519
-
Benni Mack uploaded patch set 4 10/20/22, 15:25
-
core-ci voted on patch set 4 V -1 10/20/22, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32520
-
Benni Mack uploaded patch set 5 10/20/22, 18:01
-
core-ci voted on patch set 5 V -1 10/20/22, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32522
-
Benni Mack uploaded patch set 6 10/20/22, 18:17
-
core-ci voted on patch set 6 V -1 10/20/22, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32523
-
Benni Mack uploaded patch set 7 10/20/22, 18:28
-
core-ci voted on patch set 7 V -1 10/20/22, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32525
-
Benni Mack uploaded patch set 8 10/20/22, 19:04
-
core-ci voted on patch set 8 V +1 10/20/22, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32529
-
Benni Mack uploaded patch set 9 10/21/22, 14:15
-
core-ci voted on patch set 9 V +1 10/21/22, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32587
-
Christian Kuhn commented on patch set 9 10/21/22, 21:52
-
Benni Mack commented on patch set 10 10/22/22, 09:07
Published edit on patch set 9. -
Benni Mack commented on patch set 10 10/22/22, 09:07
FormProtectionFactory.php:59Replythx. fixed. -
core-ci voted on patch set 10 V +1 10/22/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32617
-
Andreas Kienast commented on patch set 10 10/26/22, 08:39
LoginController.php:116Is "readonly" missing on purpose?FormProtectionFactory.php:326Why not self::$instances = []? -
Benni Mack uploaded patch set 11 10/28/22, 20:00
-
Benni Mack commented on patch set 11 10/28/22, 20:01
LoginController.php:116ReplyDoneFormProtectionFactory.php:326ReplyDone -
core-ci voted on patch set 11 V -1 10/28/22, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32876
-
Benni Mack uploaded patch set 12 10/28/22, 20:58
-
core-ci voted on patch set 12 V +1 10/28/22, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32877
-
Georg Ringer voted on patch set 12 V +1 CR +1 10/29/22, 16:40
-
Nikita Hovratov voted on patch set 12 CR +1 10/29/22, 18:56
-
Nikita Hovratov voted on patch set 12 V +1 10/29/22, 21:43
-
Benni Mack voted on patch set 12 V +2 CR +2 10/31/22, 09:08
-
Benni Mack merged patch set 13 10/31/22, 09:08
FormProtectionFactory.php:59