Review main Merged

76132[TASK] Replace prophecy calls in ext:seo tests

Torben Hansen CR +2 V +2 Normal +52 −42 updated 10/18/22, 07:36

Commit message

Replace all prophecy calls in ext:seo tests.

Additionally, the unit tests in HrefLangGeneratorTest
have been adapted, since the expected `getSiteLanguage`
call has been removed in #86614 and the tests actually
never checked, if `getBase` was called as expected in
the original commit in #86253.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Torben Hansen uploaded patch set 1 10/17/22, 18:02

  2. Torben Hansen updated the commit message in patch set 2 10/17/22, 18:05

  3. core-ci voted on patch set 2 V +1 10/17/22, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32405

  4. core-ci voted on patch set 1 V +1 10/17/22, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32404

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/17/22, 18:18

  6. Oliver Klee commented on patch set 2 10/17/22, 18:30

    HrefLangGeneratorTest.php:36

    These are two different statements about the behavior of the tested method: 1) that it is called 2) that it is not called Instead of covering this with a switch in the data provider, we should have to separate tests with a good name: "…IsCalled/…IsNotCalled" (For naming tests, I usually refer to this slide: https://speakerdeck.com/oliverklee/test-driven-development-with-phpunit-c87cd9b1-86df-4b61-9f0d-f098f753eb15?slide=33)
  7. Torben Hansen uploaded patch set 3 10/18/22, 05:59

  8. Torben Hansen commented on patch set 2 10/18/22, 05:59

    HrefLangGeneratorTest.php:36 Reply

    Done
  9. core-ci voted on patch set 3 V +1 10/18/22, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32413

  10. Oliver Klee voted on patch set 3 V +1 10/18/22, 07:35

  11. Oliver Klee commented on patch set 3 CR +1 10/18/22, 07:36

    Neat!
  12. Georg Ringer voted on patch set 3 V +2 CR +2 10/18/22, 07:36

  13. Georg Ringer merged patch set 4 10/18/22, 07:36