Review main Merged

76158[BUGFIX] Avoid undefined array key "exclude" in RemoteServer

Chris Müller CR +2 V +2 Easy +2 −1 updated 10/20/22, 05:02

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Chris Müller uploaded patch set 1 10/18/22, 15:55

  2. core-ci voted on patch set 1 V +1 10/18/22, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32440

  3. Oliver Klee voted on patch set 1 CR +1 10/18/22, 16:07

  4. Stefan Bürk commented on patch set 1 10/18/22, 19:41

    RemoteServer.php:152

    Should we add a `int-cast` here and change to strict check ? or a bool-cast combined with the fallback ? Would do you think ?
  5. Chris Müller uploaded patch set 2 10/19/22, 16:37

  6. Chris Müller commented on patch set 2 10/19/22, 16:38

    RemoteServer.php:152 Reply

    Done
  7. core-ci voted on patch set 2 V +1 10/19/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32470

  8. Oliver Klee voted on patch set 2 CR +1 10/19/22, 16:46

  9. Simon Schaufelberger voted on patch set 2 V +1 CR +1 10/20/22, 00:59

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 10/20/22, 05:02

  11. Stefan Bürk merged patch set 3 10/20/22, 05:02