76159[TASK] Replace prophecy calls in ext:scheduler tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1013
-
Torben Hansen uploaded patch set 1 10/18/22, 17:06
-
core-ci voted on patch set 1 V +1 10/18/22, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32441
-
Torben Hansen commented on patch set 1 CR -1 10/18/22, 17:15
on it... -
Torben Hansen voted on patch set 1 CR 0 10/18/22, 17:27
-
Oliver Klee commented on patch set 1 10/18/22, 17:29
ExecuteSchedulableCommandAdditionalFieldProviderTest.php:47Do we really need this, or can we rely on makeInstance to return a new instance? -
Torben Hansen uploaded patch set 2 10/18/22, 17:42
-
Torben Hansen commented on patch set 1 10/18/22, 17:42
ExecuteSchedulableCommandAdditionalFieldProviderTest.php:47ReplyGood catch. This is indeed not needed any more. -
core-ci voted on patch set 2 V -1 10/18/22, 17:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32442
-
Torben Hansen uploaded patch set 3 10/18/22, 17:58
-
Oliver Klee commented on patch set 3 V +1 CR +1 10/18/22, 18:05
ExecuteSchedulableCommandAdditionalFieldProviderTest.php:47ReplyDone -
core-ci voted on patch set 3 V +1 10/18/22, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32443
-
Stefan Bürk voted on patch set 3 V +2 CR +2 10/18/22, 19:43
-
Stefan Bürk merged patch set 4 10/18/22, 19:43