Review 11.5 Merged

76165[BUGFIX] Cover multi-value properties in form editor with HMAC

Oliver Hader CR +2 V +2 Easy +17 −1 updated 10/19/22, 08:20

Commit message

With #85044, HMAC validation for form definitions in the backend form
editor was introduced. However, nested multi-valued options have not
been signed with corresponding HMAC values - which lead to error
messages when persisting the form again in the backend.

The exception for `_value` and `_label` (properties used for those
multi-valued items) have been removed when generating HMAC values.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 10/19/22, 07:04

  2. core-ci voted on patch set 1 V +1 10/19/22, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32457

  3. Oliver Hader voted on patch set 1 V +2 CR +2 10/19/22, 08:20

  4. Oliver Hader merged patch set 2 10/19/22, 08:20