Review main Merged

76166[TASK] Streamline typolink LinkResult

Benni Mack CR +2 V +2 Normal +95 −155 updated 10/19/22, 09:46

Commit message

This change unifies the generation of the LinkResult
object in order to allow the generation of the LinkResult
for JSON output (EXT:headless) and HTML output,
by using the ->adapt() functionality within the typolink()
call.

The internal class (HtmlLinkResult), which was added
during v12 development, is removed in favor of the new
::adapt() method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Benni Mack uploaded patch set 1 10/19/22, 08:41

  2. core-ci voted on patch set 1 V +1 10/19/22, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32459

  3. Benni Mack commented on patch set 2 10/19/22, 08:51

    Published edit on patch set 1.
  4. Benni Mack uploaded patch set 3 10/19/22, 08:56

  5. core-ci voted on patch set 2 V +1 10/19/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32460

  6. core-ci voted on patch set 3 V +1 10/19/22, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32461

  7. Oliver Hader commented on patch set 3 V +1 CR +1 10/19/22, 09:13

    This has been extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/74374/10 - but fine!
  8. Oli Bartsch voted on patch set 3 V +1 CR +1 10/19/22, 09:46

  9. Benni Mack voted on patch set 3 V +2 CR +2 10/19/22, 09:46

  10. Benni Mack merged patch set 4 10/19/22, 09:46