Review 11.5 Merged

76167[TASK] Improve type annotations for ExpressionBuilder::literal()

Stefan Bürk CR +2 V +2 Easy +3 −3 updated 10/19/22, 12:17

Commit message

PHPStan will (correctly) unify the previous type
`\PDO::PARAM_*|Connection::PARAM_*|int` to `int` (because
`\PDO::PARAM_*` as well as `Connection::PARAM_*` are all
ints).

So we're using the stricter `Connection::PARAM_*` now, which is a
superset of `\PDO::PARAM_*`.

This allows PHPStan to catch calls to this method with
incorrect values.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 10/19/22, 12:06

  2. core-ci voted on patch set 1 V +1 10/19/22, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32465

  3. Oliver Klee voted on patch set 1 V +1 CR +1 10/19/22, 12:16

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 10/19/22, 12:17

  5. Stefan Bürk merged patch set 2 10/19/22, 12:17