Review main Merged

76192[TASK] Replace prophecy in ext:install unit tests

Stefan Bürk CR +2 V +2 Hard +99 −161 updated 10/21/22, 07:45

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1924

  1. Stefan Bürk uploaded patch set 1 10/20/22, 07:28

  2. core-ci voted on patch set 1 V -1 10/20/22, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32490

  3. Stefan Bürk uploaded patch set 2 10/20/22, 08:00

  4. core-ci voted on patch set 2 V +1 10/20/22, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32493

  5. Stefan Bürk voted on patch set 2 CR -1 10/20/22, 08:13

  6. Stefan Bürk commented on patch set 2 10/20/22, 08:18

    DocumentationFileTest.php:202

    12345 cannot be an array key, so this test is always true. the registry get prophecy does not change anything also oO this test is broken (always green) as it seems ..... no clue what it should really test
  7. Stefan Bürk updated the commit message in patch set 3 10/20/22, 08:26

  8. Stefan Bürk voted on patch set 3 CR -1 10/20/22, 08:26

  9. core-ci voted on patch set 3 V +1 10/20/22, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32496

  10. Stefan Bürk uploaded patch set 4 10/20/22, 08:37

  11. Stefan Bürk commented on patch set 4 10/20/22, 08:38

    DocumentationFileTest.php:202 Reply

    dropped it.
  12. Oliver Hader commented on patch set 4 10/20/22, 08:41

    DocumentationFileTest.php:202 Reply

    It should have tested, that `Breaking-12345-Issue.rst` is stripped of the results/files retrieved from directory `root/Changelog/1.2`.
  13. core-ci voted on patch set 4 V +1 10/20/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32497

  14. Stefan Bürk commented on patch set 4 CR -1 10/20/22, 08:45

    DocumentationFileTest.php:202 Reply

    okay. but it is not stripped at all, even not with the prophecy. will -1 the patch and look after work again into it.
  15. Stefan Bürk commented on patch set 4 CR 0 10/20/22, 18:16

    DocumentationFileTest.php:202 Reply

    That test can be dropped. `findDocumentationFiles()` do not check for filtered files using the registry ignorefiles. Thus this test is superflous now, and was not detected due "broken" (not checking anything really).
  16. Oliver Klee commented on patch set 4 10/20/22, 18:18

    DocumentationFileTest.php:192

    Why is this test removed?
  17. Oliver Klee commented on patch set 4 V +1 CR +1 10/20/22, 18:37

    DocumentationFileTest.php:192 Reply

    Ah, that’s why. :-)
  18. Stefan Bürk uploaded patch set 5 10/21/22, 00:27

  19. core-ci voted on patch set 5 V +1 10/21/22, 00:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32548

  20. Oliver Klee voted on patch set 5 V +1 CR +1 10/21/22, 07:22

  21. Anja Leichsenring voted on patch set 5 V +1 CR +1 10/21/22, 07:30

  22. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/21/22, 07:32

  23. Stefan Bürk voted on patch set 5 V +2 CR +2 10/21/22, 07:45

  24. Stefan Bürk merged patch set 6 10/21/22, 07:45