76192[TASK] Replace prophecy in ext:install unit tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+7 −15
- typo3/sysext/install/Tests/Unit/Service/CoreVersionServiceTest.php+3 −10
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+77 −98
- typo3/sysext/install/Tests/Unit/Service/Typo3tempFileServiceTest.php+6 −12
- typo3/sysext/install/Tests/Unit/UpgradeAnalysis/DocumentationFileTest.php7+6 −26
Review log 1924
-
Stefan Bürk uploaded patch set 1 10/20/22, 07:28
-
core-ci voted on patch set 1 V -1 10/20/22, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32490
-
Stefan Bürk uploaded patch set 2 10/20/22, 08:00
-
core-ci voted on patch set 2 V +1 10/20/22, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32493
-
Stefan Bürk voted on patch set 2 CR -1 10/20/22, 08:13
-
Stefan Bürk commented on patch set 2 10/20/22, 08:18
-
Stefan Bürk updated the commit message in patch set 3 10/20/22, 08:26
-
Stefan Bürk voted on patch set 3 CR -1 10/20/22, 08:26
-
core-ci voted on patch set 3 V +1 10/20/22, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32496
-
Stefan Bürk uploaded patch set 4 10/20/22, 08:37
-
Stefan Bürk commented on patch set 4 10/20/22, 08:38
DocumentationFileTest.php:202Replydropped it. -
Oliver Hader commented on patch set 4 10/20/22, 08:41
DocumentationFileTest.php:202ReplyIt should have tested, that `Breaking-12345-Issue.rst` is stripped of the results/files retrieved from directory `root/Changelog/1.2`. -
core-ci voted on patch set 4 V +1 10/20/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32497
-
Stefan Bürk commented on patch set 4 CR -1 10/20/22, 08:45
DocumentationFileTest.php:202Replyokay. but it is not stripped at all, even not with the prophecy. will -1 the patch and look after work again into it. -
Stefan Bürk commented on patch set 4 CR 0 10/20/22, 18:16
DocumentationFileTest.php:202ReplyThat test can be dropped. `findDocumentationFiles()` do not check for filtered files using the registry ignorefiles. Thus this test is superflous now, and was not detected due "broken" (not checking anything really). -
Oliver Klee commented on patch set 4 10/20/22, 18:18
DocumentationFileTest.php:192Why is this test removed? -
Oliver Klee commented on patch set 4 V +1 CR +1 10/20/22, 18:37
DocumentationFileTest.php:192ReplyAh, that’s why. :-) -
Stefan Bürk uploaded patch set 5 10/21/22, 00:27
-
core-ci voted on patch set 5 V +1 10/21/22, 00:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32548
-
Oliver Klee voted on patch set 5 V +1 CR +1 10/21/22, 07:22
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 10/21/22, 07:30
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 10/21/22, 07:32
-
Stefan Bürk voted on patch set 5 V +2 CR +2 10/21/22, 07:45
-
Stefan Bürk merged patch set 6 10/21/22, 07:45
DocumentationFileTest.php:202