76194[TASK] Convert FormRuntimeTest to a functional test
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1114
-
Elias Häußler uploaded patch set 1 10/20/22, 11:44
-
Elias Häußler uploaded patch set 2 10/20/22, 11:47
-
Oliver Klee commented on patch set 2 10/20/22, 11:54
-
core-ci voted on patch set 2 V +1 10/20/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32506
-
core-ci voted on patch set 1 V +1 10/20/22, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32505
-
Elias Häußler commented on patch set 2 10/20/22, 12:20
FormRuntimeTest.php:37ReplyIt seems like the ConfigurationManager needs a DB. At least I'm getting an exception when setting `$initializeDatabase = false` and was able to track it down to `BackendConfigurationManager::getCurrentPageIdFromCurrentSiteRoot()`. -
Oliver Klee commented on patch set 2 10/20/22, 12:33
FormRuntimeTest.php:37ReplyAck -
Christian Kuhn commented on patch set 2 10/21/22, 22:13
FormRuntimeTest.php:59globals are backed up. it should be possible to remove this. -
Christian Kuhn uploaded patch set 3 10/21/22, 22:15
-
Christian Kuhn commented on patch set 3 10/21/22, 22:17
FormRuntimeTest.php:52it would be an even better strategy to perform an actual FE request here. However, since the two existing tests only test for exceptions, the fake FE enviroment is ok for now over issues a executeFrontendSubRequest() instead. -
core-ci voted on patch set 3 V +1 10/21/22, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32607
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/21/22, 22:31
-
Stefan Bürk voted on patch set 3 V +2 CR +2 10/21/22, 22:32
-
Stefan Bürk merged patch set 4 10/21/22, 22:32
FormRuntimeTest.php:37