Review main Merged

76195[TASK] Use dependency injection in DatabaseQueryProcessor

Oli Bartsch CR +2 V +2 Easy +2 −10 updated 10/21/22, 08:31

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1417

  1. Oli Bartsch uploaded patch set 1 10/20/22, 14:28

  2. core-ci voted on patch set 1 V +1 10/20/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32518

  3. Oliver Hader commented on patch set 1 10/20/22, 15:13

    Services.yaml:146

  4. Oli Bartsch commented on patch set 1 10/20/22, 18:53

    Services.yaml:146 Reply

    In this case it's definitely needed because the FQCN is used by extensions to define the data processor in TypoScript, like core does until https://review.typo3.org/c/Packages/TYPO3.CMS/+/76162/.
  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/21/22, 07:42

  6. Jochen Roth voted on patch set 1 V +1 CR +1 10/21/22, 07:47

  7. Christian Kuhn commented on patch set 1 CR -1 10/21/22, 08:03

    DatabaseQueryProcessor.php:49

    readonly?!
  8. Oli Bartsch uploaded patch set 2 10/21/22, 08:12

  9. Christian Kuhn rebased onto patch set 3 10/21/22, 08:13

  10. Oli Bartsch commented on patch set 2 10/21/22, 08:13

    DatabaseQueryProcessor.php:49 Reply

    Done
  11. Jochen Roth voted on patch set 3 V +1 CR +1 10/21/22, 08:16

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 10/21/22, 08:20

  13. core-ci voted on patch set 2 V +1 10/21/22, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32564

  14. core-ci voted on patch set 3 V +1 10/21/22, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32565

  15. Stefan Bürk voted on patch set 3 V +1 CR +1 10/21/22, 08:26

  16. Oli Bartsch voted on patch set 3 V +2 CR +2 10/21/22, 08:31

  17. Oli Bartsch merged patch set 4 10/21/22, 08:31