Review main Merged

76197[BUGFIX] Always send strings to the method createStream

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 10/21/22, 07:13

Commit message

PHP8.1 throws an TypeError if we sending null to createStream

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 10/20/22, 18:54

  2. Oliver Klee voted on patch set 1 CR +1 10/20/22, 18:59

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/20/22, 19:00

  4. core-ci voted on patch set 1 V +1 10/20/22, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32528

  5. Georg Ringer voted on patch set 1 V +1 CR +1 10/21/22, 06:02

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/21/22, 07:13

  7. Anja Leichsenring merged patch set 2 10/21/22, 07:13