Review main Merged

76199[TASK] Replace prophecy in ext:frontend ContentDataProcessorTest

Stefan Bürk CR +2 V +2 Easy +11 −25 updated 10/21/22, 14:14

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1318

  1. Stefan Bürk uploaded patch set 1 10/20/22, 20:23

  2. Stefan Bürk uploaded patch set 2 10/20/22, 20:25

  3. Stefan Bürk uploaded patch set 3 10/20/22, 20:31

  4. core-ci voted on patch set 1 V -1 10/20/22, 20:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32532

  5. core-ci voted on patch set 2 V -1 10/20/22, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32533

  6. Stefan Bürk uploaded patch set 4 10/20/22, 20:35

  7. core-ci voted on patch set 3 V -1 10/20/22, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32535

  8. core-ci voted on patch set 4 V +1 10/20/22, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32536

  9. Torben Hansen commented on patch set 4 10/21/22, 06:32

    ContentDataProcessorTest.php:31

    Variable name should be $container, since it is not a mock object
  10. Anja Leichsenring uploaded patch set 5 10/21/22, 07:21

  11. Anja Leichsenring commented on patch set 5 V +1 CR +1 10/21/22, 07:23

    ContentDataProcessorTest.php:31 Reply

    Done
  12. Stefan Bürk commented on patch set 5 10/21/22, 07:28

    ContentDataProcessorTest.php:31 Reply

    Don't find this good. "container" may suggerate that it is a fully container/di. But also it is not mocked, it's a "test" container which is dump and only "may" eventually set test services.
  13. core-ci voted on patch set 5 V +1 10/21/22, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32560

  14. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/21/22, 13:01

  15. Andreas Kienast commented on patch set 5 10/21/22, 13:06

    ContentDataProcessorTest.php:31 Reply

    What about $containerStub then?
  16. Nikita Hovratov commented on patch set 5 10/21/22, 13:22

    ContentDataProcessorTest.php:31 Reply

    I think it's ok. No one would expect a fully loaded di container in unit tests.
  17. Stefan Bürk voted on patch set 5 V +2 CR +2 10/21/22, 14:14

  18. Stefan Bürk merged patch set 6 10/21/22, 14:14