76199[TASK] Replace prophecy in ext:frontend ContentDataProcessorTest
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1318
-
Stefan Bürk uploaded patch set 1 10/20/22, 20:23
-
Stefan Bürk uploaded patch set 2 10/20/22, 20:25
-
Stefan Bürk uploaded patch set 3 10/20/22, 20:31
-
core-ci voted on patch set 1 V -1 10/20/22, 20:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32532
-
core-ci voted on patch set 2 V -1 10/20/22, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32533
-
Stefan Bürk uploaded patch set 4 10/20/22, 20:35
-
core-ci voted on patch set 3 V -1 10/20/22, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32535
-
core-ci voted on patch set 4 V +1 10/20/22, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32536
-
Torben Hansen commented on patch set 4 10/21/22, 06:32
-
Anja Leichsenring uploaded patch set 5 10/21/22, 07:21
-
Anja Leichsenring commented on patch set 5 V +1 CR +1 10/21/22, 07:23
ContentDataProcessorTest.php:31ReplyDone -
Stefan Bürk commented on patch set 5 10/21/22, 07:28
ContentDataProcessorTest.php:31ReplyDon't find this good. "container" may suggerate that it is a fully container/di. But also it is not mocked, it's a "test" container which is dump and only "may" eventually set test services. -
core-ci voted on patch set 5 V +1 10/21/22, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32560
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 10/21/22, 13:01
-
Andreas Kienast commented on patch set 5 10/21/22, 13:06
ContentDataProcessorTest.php:31ReplyWhat about $containerStub then? -
Nikita Hovratov commented on patch set 5 10/21/22, 13:22
ContentDataProcessorTest.php:31ReplyI think it's ok. No one would expect a fully loaded di container in unit tests. -
Stefan Bürk voted on patch set 5 V +2 CR +2 10/21/22, 14:14
-
Stefan Bürk merged patch set 6 10/21/22, 14:14
ContentDataProcessorTest.php:31