Review main Merged

76214[TASK] Simplify FE page generate lock strategy

Christian Kuhn CR +2 V +2 Normal +14 −54 updated 10/21/22, 14:42

Commit message

With recent FE TS changes, we now have some information
a little earlier, which allows us to simplify the page
generation lock strategy a bit.

Until now, when two requests to the same page would still
generate different page cache entries due to different
TS condition verdicts, they block each other.

This is lifted: The page generation lock hash is
now identical to the page cache entry identifier,
requests only block each other if they really create
the same page cache entry.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1112

  1. Christian Kuhn uploaded patch set 1 10/21/22, 11:50

  2. core-ci voted on patch set 1 V +1 10/21/22, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32579

  3. Benni Mack voted on patch set 1 CR +1 10/21/22, 11:58

  4. Oliver Klee commented on patch set 1 10/21/22, 11:59

    TypoScriptFrontendController.php:1626

    While we're updating the hash anyway, should we switch the stringification from serialize to the faster json_encode (according to the numbers on https://grechin.org/2021/04/06/php-json-encode-vs-serialize-performance-comparison.html)? (And var_dump would be even slower than serialize according to https://topic.alibabacloud.com/a/performance-testing-of-array-caching-using-var_export-and-serialize-in-php-____php_1_34_20200552.html . So we shouldn't use var_dump.)
  5. Christian Kuhn commented on patch set 1 10/21/22, 12:03

    TypoScriptFrontendController.php:1626 Reply

    will think about this and may switch in another patch - i'm using serialize() currently for various cache identifiers and will switch all of them in one patch if possible.
  6. Andreas Kienast voted on patch set 1 CR +1 10/21/22, 12:05

  7. Oliver Klee commented on patch set 1 10/21/22, 12:10

    TypoScriptFrontendController.php:1626 Reply

    Ack
  8. Markus Klein voted on patch set 1 V +1 CR +1 10/21/22, 12:24

  9. Benni Mack voted on patch set 1 V +1 10/21/22, 12:24

  10. Stefan Bürk voted on patch set 1 V +1 CR +1 10/21/22, 12:49

  11. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/21/22, 14:42

  12. Anja Leichsenring merged patch set 2 10/21/22, 14:42