Review main Merged

76215[BUGFIX] Add whitespace before debug field label

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 10/21/22, 13:45

Commit message

Due to CSS changes, unnecessary margin was dropped from the `code`
element in #98349, which leads to missing spacing in the FormEngine
labels when debug information is rendered.

A whitespace character is added to such labels to get the necessary
spacing again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 10/21/22, 12:50

  2. core-ci voted on patch set 1 V +1 10/21/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32580

  3. Oliver Klee voted on patch set 1 CR +1 10/21/22, 12:59

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/21/22, 13:09

  5. Andreas Kienast uploaded patch set 2 10/21/22, 13:20

  6. core-ci voted on patch set 2 V +1 10/21/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32581

  7. Benni Mack voted on patch set 2 V +1 CR +1 10/21/22, 13:45

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 10/21/22, 13:45

  9. Andreas Kienast merged patch set 3 10/21/22, 13:45