Review main Merged

76216[BUGFIX] Add basic validation for email and phone links

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 10/21/22, 14:36

Commit message

To avoid setting potentially invalid links, the "email address" and
"telephone number" fields both are marked as "required". The input type
of the former one is also changed to `email`.

As a drive-by fix, `id` and `for` properties are set to link the input
fields to their respective label.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 10/21/22, 13:20

  2. Andreas Kienast uploaded patch set 2 10/21/22, 13:21

  3. Nikita Hovratov voted on patch set 2 CR +1 10/21/22, 13:24

  4. core-ci voted on patch set 2 V +1 10/21/22, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32583

  5. core-ci voted on patch set 1 V +1 10/21/22, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32582

  6. Benni Mack voted on patch set 2 V +1 CR +1 10/21/22, 13:47

  7. Oliver Klee voted on patch set 2 CR +1 10/21/22, 13:56

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/21/22, 14:36

  9. Anja Leichsenring merged patch set 3 10/21/22, 14:36