76224[TASK] Optimize FE page locking
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1215
-
Christian Kuhn uploaded patch set 1 10/21/22, 17:42
-
core-ci voted on patch set 1 V +1 10/21/22, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32594
-
Christian Kuhn uploaded patch set 2 10/21/22, 17:53
-
core-ci voted on patch set 2 V +1 10/21/22, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32595
-
Andreas Kienast voted on patch set 2 CR +1 10/21/22, 19:35
-
Stefan Bürk commented on patch set 2 CR -1 10/21/22, 19:47
ResourceMutex.php:99$hadToWaitForLock should be set here to true - as we are now going to to wait and try again (usleep + continue loop) -
Christian Kuhn commented on patch set 2 10/21/22, 20:02
ResourceMutex.php:85Replyoops. thx.ResourceMutex.php:99Replyyeah. mixed that up since i renamed that property twice ... thx! -
Christian Kuhn uploaded patch set 3 10/21/22, 20:10
-
Christian Kuhn commented on patch set 3 10/21/22, 20:10
ResourceMutex.php:85ReplyDoneResourceMutex.php:99ReplyDone -
Stefan Bürk voted on patch set 3 V +1 CR +1 10/21/22, 20:12
-
core-ci voted on patch set 3 V +1 10/21/22, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32599
-
Markus Klein commented on patch set 3 10/22/22, 08:58
ResourceMutex.php:100Param is still here -
Markus Klein commented on patch set 3 V +1 CR +1 10/22/22, 09:00
ResourceMutex.php:100Replyokay, we do not document those anymore as well. fine with me -
Christian Kuhn voted on patch set 3 V +2 CR +2 10/22/22, 10:03
-
Christian Kuhn merged patch set 4 10/22/22, 10:03
ResourceMutex.php:85