Review main Merged

76231[BUGFIX] Ensure proper test setup related to doctrine/dbal

Stefan Bürk CR +2 V +2 Easy +3 −10 updated 10/23/22, 09:15

Commit message

With doctrine/dbal v3.5.0 some changes has been introduced which
shows invalid test setup. This change use proper test setup to be
okay again, if doctrine/dbal v3.5.0 is used.

See: https://github.com/doctrine/dbal/pull/5770

Used command(s):

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Stefan Bürk uploaded patch set 1 10/23/22, 05:53

  2. core-ci voted on patch set 1 V -1 10/23/22, 06:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32631

  3. Stefan Bürk uploaded patch set 2 10/23/22, 06:19

  4. core-ci voted on patch set 2 V +1 10/23/22, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32633

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/23/22, 07:08

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 10/23/22, 09:14

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 10/23/22, 09:15

  8. Stefan Bürk merged patch set 3 10/23/22, 09:15