Review main Merged

76232[BUGFIX] Ensure table renaming works due doctrine/dbal behaviour change

Stefan Bürk CR +2 V +2 Easy +23 −1 updated 10/24/22, 11:42

Commit message

doctrine/dbal is working on deprecating and changing code and
behaviour in 3.x as preparation for removal in 4.x. Starting
with doctrine/dbal v3.5.0, the table rename detection in the
TYPO3 database compare no longer works as expected. TableDiff
got an `isEmpty()` check, which is used in SchemaDiff and thus
filtering out "renamed" tables without further changes, leading
to a change of behavior. doctrine/dbal favors renaming table
no longer by setting a new name in the TableDiff, thus not having
the changed name in the `isEmpty()` check.

See: https://github.com/doctrine/dbal/pull/5770

doctrine/dbal deprecations and changes require systematical
adoption to cover all the changes. This takes time and proper
testing, which is out of the scope for this change.

This change overrides the `TableDiff->isEmpty()` method in the
corresponding core fascade class, adding checks for $newName
and $tableOptions checks as a intermediate workaround. Thus
keep compatibillity between doctrine/dbal <3.5 and 3.5 for now.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2335

Show 610 earlier messages
  1. Stefan Bürk uploaded patch set 1 10/23/22, 06:17

  2. core-ci voted on patch set 1 V -1 10/23/22, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32632

  3. Stefan Bürk uploaded patch set 2 10/23/22, 06:36

  4. Stefan Bürk uploaded patch set 3 10/23/22, 06:37

  5. core-ci voted on patch set 2 V +1 10/23/22, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32634

  6. core-ci voted on patch set 3 V +1 10/23/22, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32635

  7. Stefan Bürk uploaded patch set 4 10/23/22, 07:01

  8. core-ci voted on patch set 4 V +1 10/23/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32636

  9. Stefan Bürk rebased onto patch set 5 10/23/22, 09:15

  10. Andreas Kienast voted on patch set 5 CR +1 10/23/22, 09:16

  1. core-ci voted on patch set 5 V +1 10/23/22, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32639

  2. Stefan Bürk commented on patch set 5 10/23/22, 09:25

    Running nightly on it, as second patch related to failing nightly has been merged. Pipeline: https://git.typo3.org/typo3/CI/cms/-/pipelines/32641
  3. Stefan Bürk voted on patch set 5 CR -1 10/23/22, 09:52

  4. core-ci voted on patch set 5 V -1 10/23/22, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32641

  5. Oliver Klee updated the commit message in patch set 6 10/23/22, 10:08

  6. core-ci voted on patch set 6 V +1 10/23/22, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32645

  7. Stefan Bürk voted on patch set 6 CR -1 10/23/22, 10:17

  8. Stefan Bürk uploaded patch set 7 10/23/22, 10:35

  9. Stefan Bürk uploaded patch set 8 10/23/22, 10:36

  10. Stefan Bürk voted on patch set 8 CR -1 10/23/22, 10:38

  11. Stefan Bürk uploaded patch set 9 10/23/22, 10:42

  12. Stefan Bürk voted on patch set 9 CR -1 10/23/22, 10:43

  13. core-ci voted on patch set 9 V +1 10/23/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32650

  14. Stefan Bürk commented on patch set 9 10/23/22, 11:01

    Reply

    Running nightly again on Patchset 9: https://git.typo3.org/typo3/CI/cms/-/pipelines/32652
  15. Stefan Bürk voted on patch set 9 CR 0 10/23/22, 11:18

  16. core-ci voted on patch set 9 V -1 10/23/22, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32652

  17. core-ci commented on patch set 9 10/23/22, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32652

  18. core-ci voted on patch set 9 V +1 10/23/22, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32652

  19. Oliver Klee commented on patch set 9 10/23/22, 12:05

    Reply

    Looks green!
  20. Stefan Bürk updated the commit message in patch set 10 10/24/22, 06:32

  21. core-ci voted on patch set 10 V +1 10/24/22, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32673

  22. Christian Kuhn voted on patch set 10 V +1 CR +1 10/24/22, 11:31

  23. Benni Mack voted on patch set 10 V +1 CR +1 10/24/22, 11:40

  24. Stefan Bürk voted on patch set 10 V +2 CR +2 10/24/22, 11:42

  25. Stefan Bürk merged patch set 11 10/24/22, 11:42