Review main Merged

76235[BUGFIX] Rename event variable in multi-delete handler

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 10/29/22, 16:36

Commit message

The patch for #98288 accidentally overwrote the variable of the event in
the event handler for deleting multiple files. The event variables in
the modal button callbacks are renamed now.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 10/23/22, 10:04

  2. Andreas Kienast uploaded patch set 2 10/23/22, 10:05

  3. core-ci voted on patch set 1 V +1 10/23/22, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32643

  4. core-ci voted on patch set 2 V +1 10/23/22, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32644

  5. Benni Mack voted on patch set 2 V +1 CR +1 10/27/22, 09:38

  6. Oliver Klee voted on patch set 2 CR +1 10/27/22, 11:07

  7. Georg Ringer voted on patch set 2 V +2 CR +2 10/29/22, 16:36

  8. Georg Ringer merged patch set 3 10/29/22, 16:36