Review main Merged

76236[BUGFIX] Apply overflow to body in iframe loaded in modal

Andreas Kienast CR +2 V +2 Easy +18 −13 updated 11/17/22, 09:00

Commit message

In TYPO3 v8, a "rebounce" protection was added to deny overscrolling
the document on iOS devices (aka "rubber band effect"). This caused an
issue in #98348 where the shortcut menu opened to the wrong side and
the rubber band fix got partially reverted, breaking modals where the
content is intended to be scrollable.

Also, the scaffold is "broken" on Apple devices as `100vh` is treated as
"100vh if the address bar is shrunk", leading to a larger and thus
scrollable scaffold when using `overscroll-behavior: none` [1], which
would've been the preferred solution to solve the scrolling issue.

The solution for the scrollable scaffold are dynamic viewport
units [2], but those are not supported in all browsers, yet, and also
revert `overscroll-behavior` (tested with iPadOS 16.1).

To have the original issue fixed somehow, a workaround now adds the CSS
class `with-overflow` to the `body` tag to all iframes rendered in
modals.

[1] https://caniuse.com/css-overscroll-behavior
[2] https://caniuse.com/viewport-unit-variants

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1320

  1. Andreas Kienast uploaded patch set 1 10/23/22, 10:41

  2. core-ci voted on patch set 1 V +1 10/23/22, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32649

  3. Riccardo De Contardi commented on patch set 1 V +1 10/23/22, 16:29

    Tested on latest main with the following modals - page link - file link - add image
  4. Andreas Kienast commented on patch set 1 V -1 CR -1 10/24/22, 06:36

    This patch enables the "refresh on pull down" feature on iOS, making the backend completely unusable.
  5. Andreas Kienast uploaded patch set 2 10/24/22, 17:14

  6. core-ci voted on patch set 2 V +1 10/24/22, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32706

  7. Andreas Kienast uploaded patch set 3 10/27/22, 11:50

  8. core-ci voted on patch set 3 V +1 10/27/22, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32838

  9. Andreas Kienast updated the commit message in patch set 4 10/27/22, 12:05

  10. core-ci voted on patch set 4 V +1 10/27/22, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32839

  11. Andreas Kienast uploaded patch set 5 10/28/22, 07:43

  12. core-ci voted on patch set 5 V +1 10/28/22, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32866

  13. Andreas Kienast rebased onto patch set 6 11/15/22, 07:13

  14. core-ci voted on patch set 6 V +1 11/15/22, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33732

  15. Andreas Kienast uploaded patch set 7 11/16/22, 13:25

  16. core-ci voted on patch set 7 V +1 11/16/22, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33827

  17. Frank Nägler commented on patch set 7 V +1 CR +1 11/16/22, 13:49

    tested with chrome and safari on mac and safari on ipad.
  18. Benni Mack voted on patch set 7 V +1 CR +1 11/17/22, 08:55

  19. Andreas Kienast voted on patch set 7 V +2 CR +2 11/17/22, 08:59

  20. Andreas Kienast merged patch set 8 11/17/22, 09:00