Review main Merged

76239[FEATURE] Add TypoScript as Request attribute

Christian Kuhn CR +2 V +2 Hard +542 −453 updated 10/25/22, 14:52

Commit message

The patch introduces the new request attribute
TypoScriptRequestAttribute as 'frontend.typoscript'.

It is set up in the Frontend middleware chain,
extensions and content objects can use this
attribute to retrieve TypoScript settings and
setup.

This obsoletes usages of TSFE->tmpl, the patch
switches usages to the request attribute.

Note we're also establishing a better wording:
The old TypoScript 'constants' are now called
'settings'. This matches much better, should avoid
confusion for newcomers and is in line with further
renaming of a vaguely anticipated new 'constants
editor' towards 'settings editing' or similar.
Further patches in this naming area will follow.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 31

Show 11 more files

Review log 3155

Show 1630 earlier messages
  1. Christian Kuhn uploaded patch set 1 10/23/22, 12:43

  2. core-ci voted on patch set 1 V -1 10/23/22, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32657

  3. Christian Kuhn uploaded patch set 2 10/24/22, 07:53

  4. core-ci voted on patch set 2 V +1 10/24/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32674

  5. Christian Kuhn uploaded patch set 3 10/24/22, 09:22

  6. core-ci voted on patch set 3 V -1 10/24/22, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32676

  7. Christian Kuhn uploaded patch set 4 10/24/22, 10:37

  8. core-ci voted on patch set 4 V +1 10/24/22, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32679

  9. Christian Kuhn uploaded patch set 5 10/24/22, 10:56

  10. Christian Kuhn uploaded patch set 6 10/24/22, 12:58

  11. Christian Kuhn uploaded patch set 7 10/24/22, 13:00

  12. core-ci voted on patch set 6 V -1 10/24/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32685

  13. core-ci voted on patch set 7 V +1 10/24/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32686

  14. Christian Kuhn uploaded patch set 8 10/24/22, 13:26

  15. core-ci voted on patch set 8 V +1 10/24/22, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32687

  16. Christian Kuhn uploaded patch set 9 10/24/22, 13:49

  17. Christian Kuhn uploaded patch set 10 10/24/22, 13:56

  18. core-ci voted on patch set 9 V +1 10/24/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32688

  19. Christian Kuhn uploaded patch set 11 10/24/22, 13:59

  20. core-ci voted on patch set 10 V -1 10/24/22, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32690

  21. core-ci voted on patch set 11 V +1 10/24/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32691

  22. Christian Kuhn uploaded patch set 12 10/24/22, 14:12

  23. core-ci voted on patch set 12 V +1 10/24/22, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32692

  24. Christian Kuhn uploaded patch set 13 10/24/22, 15:13

  25. Christian Kuhn uploaded patch set 14 10/24/22, 15:16

  26. Christian Kuhn uploaded patch set 15 10/24/22, 15:20

  27. core-ci voted on patch set 13 V -1 10/24/22, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32700

  28. core-ci voted on patch set 14 V -1 10/24/22, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32701

  29. core-ci voted on patch set 15 V -1 10/24/22, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32702

  30. Christian Kuhn uploaded patch set 16 10/25/22, 06:44

  1. core-ci voted on patch set 16 V -1 10/25/22, 06:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32717

  2. Christian Kuhn uploaded patch set 17 10/25/22, 07:21

  3. core-ci voted on patch set 17 V -1 10/25/22, 07:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32718

  4. Christian Kuhn uploaded patch set 18 10/25/22, 07:30

  5. core-ci voted on patch set 18 V +1 10/25/22, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32719

  6. Christian Kuhn uploaded patch set 19 10/25/22, 07:55

  7. core-ci voted on patch set 19 V +1 10/25/22, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32720

  8. Christian Kuhn uploaded patch set 20 10/25/22, 08:28

  9. core-ci voted on patch set 20 V +1 10/25/22, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32724

  10. Christian Kuhn uploaded patch set 21 10/25/22, 09:01

  11. core-ci voted on patch set 21 V +1 10/25/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32726

  12. Christian Kuhn uploaded patch set 22 10/25/22, 09:10

  13. core-ci voted on patch set 22 V +1 10/25/22, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32727

  14. Christian Kuhn uploaded patch set 23 10/25/22, 10:16

  15. core-ci voted on patch set 23 V -1 10/25/22, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32729

  16. Christian Kuhn uploaded patch set 24 10/25/22, 10:26

  17. core-ci voted on patch set 24 V +1 10/25/22, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32731

  18. Christian Kuhn commented on patch set 24 CR -1 10/25/22, 12:03

    talked with benni: we'll strategically rename and move some details.
  19. Christian Kuhn uploaded patch set 25 10/25/22, 13:36

  20. core-ci voted on patch set 25 V +1 10/25/22, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32743

  21. Stefan Bürk voted on patch set 25 CR +1 10/25/22, 14:07

  22. Benni Mack voted on patch set 25 V +1 CR +1 10/25/22, 14:08

  23. Stefan Bürk commented on patch set 25 V +1 10/25/22, 14:13

    nice one
  24. Christian Kuhn voted on patch set 25 V +2 CR +2 10/25/22, 14:52

  25. Christian Kuhn merged patch set 26 10/25/22, 14:52