Review main Merged

7624[BUGFIX] Resetting of input field to default when having a range fails

anonymized-50850 CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

When trying to reset a endtime (datetime or date) having a range (like tt_news
articles) the lower range limit will be stored instead of the default value.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Wouter Wolters +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Wouter Wolters +1

Files 1

Review log 11

  1. Tolleiv Nietsch uploaded patch set 2 02/10/12, 08:02

  2. Tolleiv Nietsch commented on patch set 2 02/10/12, 08:02

    Verified; Looks good to me, but someone else must approve Just changed the commit message --- besides that the patch is working fine.
  3. Tolleiv Nietsch commented on patch set 2 V 0 02/10/12, 08:02

    by team member; Looks good to me, approved
  4. Philipp Gampe commented on patch set 1 02/10/12, 08:02

    Must the range value be an int value?
  5. Philipp Gampe commented on patch set 1 02/10/12, 08:02

    Looks good to me, but someone else must approve Seems like in current TCA, it says that range must be integer. http://typo3.org/documentation/document-library/core-documentation/doc_core_tca/4.6.0/view/1/3/#id2619168 So your change looks ok. Could you please wrap the commit message after 72 chars (no need to do this now - lets wait for other reviews first, but should be done before merge).
  6. anonymized-50850 commented on patch set 1 02/10/12, 08:02

    Hm, for the range it does say integer. but for the default value it says "whatever is appropriate for the given field". i'm not quite sure about this...
  7. anonymized-50850 commented on patch set 1 02/10/12, 08:02

    hm, i guess it could be an float/double too... are there any examples on that?
  8. Mr. Jenkins commented on patch set 1 02/10/12, 08:02

  9. Mr. Jenkins commented on patch set 2 02/10/12, 08:02

  10. Wouter Wolters commented on patch set 2 02/10/12, 08:02

    Verified; Looks good to me, but someone else must approve
  11. Tolleiv Nietsch merged patch set 2 02/10/12, 08:02