Review main Merged

76242[TASK] GifBuilder: Use CharRangeMap from configuration

Benni Mack CR +2 V +2 Easy +9 −13 updated 10/24/22, 12:02

Commit message

The global charRangeMap option in TypoScript / GIFBUILDER
allows to define the pixelSpace (with a multiplicator for the fontSize)
for certain fonts.

However, it is not possible to define this per GIFBUILDER
rendering due to the access on TSFE.

Instead, the local charRangeMap of the GIFBUILDER configuration
array is used to allow the charRangeMap per generated image.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 10/24/22, 11:15

  2. core-ci voted on patch set 1 V -1 10/24/22, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32681

  3. Christian Kuhn uploaded patch set 2 10/24/22, 11:28

  4. core-ci voted on patch set 2 V +1 10/24/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32682

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/24/22, 11:43

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 10/24/22, 12:02

  7. Christian Kuhn merged patch set 3 10/24/22, 12:02