Review main Merged

7625[BUGFIX] User Admin: Move "Add" button to docheader

Felix Kopp CR +2 V +2 Easy +9 −6 updated 06/03/13, 20:49

Commit message

Move the "Add User" button in "User Admin" module to the docheader.

Review

  • Code review CR +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Files 2

Review log 8

  1. Steffen Gebert merged patch set 1 01/06/12, 20:32

  2. Georg Ringer commented on patch set 1 01/06/12, 20:32

    (2 inline comments)

    index.php:1186

    strict comparison ===

    index.php:1191

    wanna assign $buttons['add'] directly the content without using $link_createNewUser? would be even shorter name
  3. Steffen Gebert uploaded patch set 2 01/06/12, 20:32

  4. Steffen Gebert commented on patch set 2 V 0 01/06/12, 20:32

    by team member; Looks good to me, approved Implemented Georg's suggestions.
  5. Philipp Gampe commented on patch set 1 01/06/12, 20:32

    Verified; Looks good to me, but someone else must approve Works
  6. Simon Schaufelberger commented on patch set 1 01/06/12, 20:32

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 01/06/12, 20:32

  8. Mr. Jenkins commented on patch set 2 01/06/12, 20:32