Review main Merged

76253[TASK] Update to PHPStan 1.8.11

Oliver Klee CR +2 V +2 Easy +17 −27 updated 10/25/22, 10:42

Commit message

Also update the PHPUnit PHPStan configuration.

This update gets rid of some false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.8.11
> composer req --dev phpstan/phpstan-phpunit:^1.1.3
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oliver Klee uploaded patch set 1 10/25/22, 08:09

  2. core-ci voted on patch set 1 V +1 10/25/22, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32722

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/25/22, 08:31

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/25/22, 08:45

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/25/22, 10:42

  6. Christian Kuhn merged patch set 2 10/25/22, 10:42