Review main Merged

76254[TASK] Replace prophecy in EXT:frontend AbstractMenuContentObjectTest

Nikita Hovratov CR +2 V +2 Normal +35 −44 updated 10/25/22, 13:55

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Nikita Hovratov uploaded patch set 1 10/25/22, 08:27

  2. core-ci voted on patch set 1 V +1 10/25/22, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32723

  3. Simon Schaufelberger commented on patch set 1 10/25/22, 10:12

    AbstractMenuContentObjectTest.php:80

    i prefer to put the "with" before the "willReturn" as it follows more the code flow (first the input, then the return)
  4. Nikita Hovratov uploaded patch set 2 10/25/22, 10:37

  5. Nikita Hovratov commented on patch set 2 10/25/22, 10:37

    AbstractMenuContentObjectTest.php:80 Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/25/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32734

  7. Stefan Bürk updated the commit message in patch set 3 10/25/22, 11:08

  8. core-ci voted on patch set 3 V +1 10/25/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32736

  9. Georg Ringer voted on patch set 3 V +1 CR +1 10/25/22, 12:44

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 10/25/22, 13:55

  11. Christian Kuhn merged patch set 4 10/25/22, 13:55