Review main Merged

76255[TASK] Replace prophecy in EXT:frontend ProductionExceptionHandlerTest

Nikita Hovratov CR +2 V +2 Normal +17 −40 updated 10/25/22, 11:07

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Nikita Hovratov uploaded patch set 1 10/25/22, 08:43

  2. core-ci voted on patch set 1 V +1 10/25/22, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32725

  3. Georg Ringer voted on patch set 1 V +1 CR +1 10/25/22, 09:30

  4. Simon Schaufelberger commented on patch set 1 10/25/22, 10:10

    ProductionExceptionHandlerTest.php:82

    I would put the "with" before the willReturn to have a more consistent flow of what is going on
  5. Nikita Hovratov uploaded patch set 2 10/25/22, 10:35

  6. Nikita Hovratov commented on patch set 2 10/25/22, 10:37

    ProductionExceptionHandlerTest.php:82 Reply

    Done
  7. core-ci voted on patch set 2 V +1 10/25/22, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32733

  8. Christian Kuhn commented on patch set 2 CR -1 10/25/22, 10:46

    on it.
  9. Christian Kuhn uploaded patch set 3 10/25/22, 10:53

  10. core-ci voted on patch set 3 V +1 10/25/22, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32735

  11. Georg Ringer voted on patch set 3 V +1 CR +1 10/25/22, 11:02

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 10/25/22, 11:07

  13. Christian Kuhn merged patch set 4 10/25/22, 11:07